Skip to content

Commit 8a256cd

Browse files
committed
fix : detekt workflow bug fix
1 parent c0d7e35 commit 8a256cd

File tree

5 files changed

+22
-15
lines changed

5 files changed

+22
-15
lines changed

.github/workflows/android-tests.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ jobs:
3838
- uses: actions/checkout@v2
3939
- name: Grant execute permission for gradlew
4040
run: chmod +x gradlew
41-
- name: Decode BASEURL
42-
run: echo API_BASE_URL=TEST > ./local.properties
4341
- name: Config Luffy API
4442
env:
4543
Y: ${{secrets.API_BASE_URL}}

.github/workflows/detekt-analysis.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,23 +30,23 @@ jobs:
3030

3131
- name: Grant execute permission for gradlew
3232
run: chmod +x gradlew
33-
- name: Run Detekt
34-
run: ./gradlew detekt
3533
- name: Config Luffy API
3634
env:
3735
Y: ${{secrets.API_BASE_URL}}
3836
run: echo -e "API_BASE_URL=$Y \n" >> ./local.properties
3937
- name: Config Avatar API
4038
env:
41-
X : ${{secrets.AVATAR_API}}
39+
X: ${{secrets.AVATAR_API}}
4240
run: echo -e "AVATAR_API=$X \n" >> ./local.properties
4341
- name: Config RabbitMQ
4442
env:
45-
A : ${{secrets.RABBITMQ_HOST}}
46-
B : ${{secrets.RABBITMQ_PORT}}
47-
C : ${{secrets.RABBIT_USER_NAME}}
48-
D : ${{secrets.RABBIT_USER_PASSWORD}}
43+
A: ${{secrets.RABBITMQ_HOST}}
44+
B: ${{secrets.RABBITMQ_PORT}}
45+
C: ${{secrets.RABBIT_USER_NAME}}
46+
D: ${{secrets.RABBIT_USER_PASSWORD}}
4947
run: echo -e "RABBITMQ_HOST=$A\nRABBITMQ_PORT=$B\nRABBIT_USER_NAME=$C\nRABBIT_USER_PASSWORD=$D" >> ./local.properties
48+
- name: Run Detekt
49+
run: ./gradlew detekt
5050
# Make sure we always run this upload task,
5151
# because the previous step may fail if there are findings.
5252
- uses: github/codeql-action/upload-sarif@v1

.idea/detekt.xml

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ UI is utilising a dual-theme approach, allowing users to choose from light or da
6363
![kotlin](./assets/mad/kotlin.png)
6464

6565
## Architecture
66-
NarutoDex is based on MVVM architecture and a repository pattern.
66+
Zoro is based on MVVM architecture and a repository pattern.
6767

6868
![architecture](/assets/architecture/mvvm.png)
6969

app/build.gradle

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ android {
2121
minSdk 28
2222
targetSdk 31
2323
versionCode 1
24-
versionName "1.0"
24+
versionName "1.0.1"
2525

2626
javaCompileOptions {
2727
annotationProcessorOptions {
@@ -106,9 +106,9 @@ def getRabbitPassword() {
106106

107107
dependencies {
108108
implementation 'androidx.core:core-ktx:1.7.0'
109-
implementation 'androidx.appcompat:appcompat:1.4.0'
110-
implementation 'com.google.android.material:material:1.4.0'
111-
implementation 'androidx.constraintlayout:constraintlayout:2.1.2'
109+
implementation 'androidx.appcompat:appcompat:1.4.1'
110+
implementation 'com.google.android.material:material:1.5.0'
111+
implementation 'androidx.constraintlayout:constraintlayout:2.1.3'
112112
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
113113

114114
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2'
@@ -143,7 +143,7 @@ dependencies {
143143
kapt "androidx.room:room-compiler:$room_version"
144144
implementation "androidx.room:room-ktx:$room_version"
145145
// optional - Paging 3 Integration
146-
implementation "androidx.room:room-paging:2.4.0"
146+
implementation "androidx.room:room-paging:$room_version"
147147

148148
def retrofit_ver = "2.9.0"
149149
implementation "com.squareup.retrofit2:retrofit:$retrofit_ver"

0 commit comments

Comments
 (0)