feat(ci-checks): add workflow to run rspec and jest on PR (#1404)

Author: andypf

.github/pull_request_template.md

@@ -0,0 +1,32 @@
+# Summary
+
+<!-- Provide a short summary explaining the purpose of this pull request. -->
+
+# Changes Made
+
+<!-- List the changes that were made in this pull request. -->
+
+- Change 1
+- Change 2
+- Change 3
+
+# Related Issues
+
+<!-- List any related issues or tickets, including links to them. -->
+
+- Issue 1: #ISSUE_ID
+
+# Screenshots (if applicable)
+
+<!-- If there are any visual changes, provide screenshots or GIFs. -->
+
+# Checklist
+
+<!-- Ensure that your pull request meets the following requirements. -->
+
+- [ ] I have performed a self-review of my code.
+- [ ] I have commented my code, particularly in hard-to-understand areas.
+- [ ] I have added tests that prove my fix is effective or that my feature works.
+- [ ] New and existing unit tests pass locally with my changes.
+- [ ] I have made corresponding changes to the documentation (if applicable).
+- [ ] My changes generate no new warnings or errors.

.github/workflows/ci-checks.yaml

@@ -0,0 +1,77 @@
+name: CI Check
+
+on:
+  pull_request:
+    types:
+      - opened
+      - synchronize
+      - reopened
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    container:
+      image: ruby:3.2
+
+    services:
+      postgres:
+        image: postgres:16
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: "postgres"
+          POSTGRES_DB: postgres
+          POSTGRES_HOST_AUTH_METHOD: trust
+        ports:
+        - 5432:5432
+        # needed because the postgres container does not provide a healthcheck
+        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
+
+    steps:
+    - uses: actions/checkout@v1
+
+    - uses: actions/setup-node@v1
+      with:
+        node-version: '20'
+        registry-url: 'https://registry.npmjs.org'
+
+    - name: Gem cache
+      id: cache-bundle
+      uses: actions/cache@v1
+      with:
+        path: vendor/bundle
+        key: bundle-${{ hashFiles('**/Gemfile.lock') }}
+
+    - name: Bundle install
+      env:
+        RAILS_ENV: test
+      run: |
+        gem install bundler
+        bundle install --jobs 4 --retry 3 --path vendor/bundle
+    - name: Install yarn
+      run: npm install -g yarn
+
+    - name: Get yarn cache dir
+      id: yarn-cache-dir
+      run: echo "::set-output name=dir::$(yarn cache dir)"
+
+    - name: Yarn cache
+      id: cache-yarn
+      uses: actions/cache@v1
+      with:
+        path: ${{ steps.yarn-cache-dir.outputs.dir }}
+        key: yarn-${{ hashFiles('**/yarn.lock') }}
+
+    - name: Setup DB, Run tests
+      env:
+        POSTGRES_SERVICE_HOST: postgres
+        PGUSER: postgres
+        PGPORT: 5432
+        RAILS_ENV: test
+      run: |
+        bin/rails db:create db:schema:load
+        bundle exec rspec
+
+    - name: Yarn install
+      run: |
+        yarn install
+        yarn test

app/javascript/lib/components/search_field.jsx

@@ -1,4 +1,4 @@
-import { SearchInput } from "juno-ui-components/build/SearchInput"
+import { SearchInput } from "@cloudoperators/juno-ui-components/build/SearchInput"
 import React from "react"
 import { Popover } from "./Overlay"
 

app/javascript/tailwind.scss

@@ -1,4 +1,4 @@
-@import "juno-ui-components/build/lib/variables";
+@import "@cloudoperators/juno-ui-components/build/lib/variables";
 @import "tailwindcss/base";
 @import "tailwindcss/components";
-@import "tailwindcss/utilities";
+@import "tailwindcss/utilities";

docker/Dockerfile

@@ -82,7 +82,6 @@ ADD . $APP_PATH
 
 # transpile javascripts
 #RUN yarn install --no-progress && yarn build --production && rm -rf node_modules
-RUN yarn upgrade juno-ui-components
 RUN bin/rails assets:precompile && rm -rf node_modules
 
 RUN echo $(git rev-parse HEAD) > $APP_PATH/REVISION && rm -rf .git

docker/Dockerfile.dev

@@ -1,4 +1,4 @@
-FROM keppel.eu-de-1.cloud.sap/ccloud-dockerhub-mirror/library/ruby:3.2.2-alpine3.17
+FROM keppel.eu-de-1.cloud.sap/ccloud-dockerhub-mirror/library/ruby:3.2.2-alpine3.19
 
 LABEL source_repository="https://github.wdf.sap.corp/monsoon/workspaces/tree/master/environments/elektra"
 
@@ -15,9 +15,9 @@ RUN apk upgrade --no-cache --no-progress \
   build-base \
   npm \
   --virtual .builddeps \
-  postgresql15-dev \
-  postgresql15-jit \
-  postgresql15-client \
+  postgresql16-dev \
+  postgresql16-jit \
+  postgresql16-client \
   openssh \
   yarn \
   bash \
@@ -27,22 +27,35 @@ RUN apk upgrade --no-cache --no-progress \
   vim \
   shared-mime-info \
   python3 \
+  python3-dev \
   py3-pip\
+  py3-werkzeug \
   ca-certificates \
   gcc \
   libffi-dev \
-  python3-dev \
   musl-dev \
   openssl-dev \
   g++ libxml2-dev \
   libxslt-dev \
   libjpeg-turbo-dev \
   zlib-dev \
-  tshark 
+  tshark \
+  rust \
+  cargo
+# Create and activate a virtual environment
+RUN python3 -m venv /opt/venv
+
+# Make sure the venv Python is used by default
+ENV PATH="/opt/venv/bin:$PATH"
+RUN echo 'export PATH="/opt/venv/bin:$PATH"' >> /etc/profile
 
-RUN pip install --upgrade pip
+# Install Python packages in the virtual environment
 # werkzeug==2.2.2 -> https://stackoverflow.com/questions/77213053/why-did-flask-start-failing-with-importerror-cannot-import-name-url-quote-fr
-RUN pip install mitmproxy==8.1.1 pgcli werkzeug==2.2.2
+RUN pip install werkzeug==2.2.2 mitmproxy==9.0.0
+
+# Verify installation
+RUN mitmproxy --version
+
 ENV LANG=en_US.UTF-8
 
 RUN mkdir /app
@@ -57,7 +70,6 @@ ENV PGDATA /app/tmp/postgresql/data
 RUN gem install bundler -v 2.3.20 && bundle config set --local path 'vendor/bundle'
 RUN echo -e '#!/bin/bash\n\n\
   bundle install \n\
-  yarn upgrade juno-ui-components \n\
   yarn \n\
   mkdir -p "$PGDATA" && chown -R postgres:postgres "$PGDATA"\n\
   PGDATA_FILES=$(ls -A $PGDATA)\n\
@@ -68,7 +80,7 @@ RUN echo -e '#!/bin/bash\n\n\
   mkdir -p /var/run/postgresql && chown -R postgres:postgres /var/run/postgresql\n\
   su - postgres -c "pg_ctl -D $PGDATA -w start"\n\
   DISABLE_SPRING=1 bin/rails db:create && DISABLE_SPRING=1 bin/rails db:migrate\n\
-  /bin/bash -login' >> /usr/local/bin/prepare-elektra && chmod +x /usr/local/bin/prepare-elektra
+  exec /bin/bash --login' >> /usr/local/bin/prepare-elektra && chmod +x /usr/local/bin/prepare-elektra
 
 RUN echo -e '\n\
   #!/bin/bash\n\n\

docker/Dockerfile.jest-tests

@@ -1,5 +1,5 @@
 # needs to be in sync with node version in elektra image!
-FROM keppel.eu-de-1.cloud.sap/ccloud-dockerhub-mirror/library/node:18-alpine
+FROM keppel.eu-de-1.cloud.sap/ccloud-dockerhub-mirror/library/node:20-alpine
 
 LABEL source_repository="https://github.com/sapcc/elektra"
 

lib/generators/templates/juno/app/javascript/widgets/app/components/Application.jsx

@@ -13,7 +13,7 @@ import NewEntryModal from "./entries/new"
 import StateProvider from "./StateProvider"
 import styles from "../styles.css"
 
-import StyleProvider, { AppShell } from "juno-ui-components"
+import StyleProvider, { AppShell } from "@cloudoperators/juno-ui-components"
 import { BrowserRouter } from "react-router-dom/cjs/react-router-dom.min"
 import { widgetBasePath } from "lib/widget"
 

lib/generators/templates/juno/app/javascript/widgets/app/components/Tabs.jsx

@@ -1,6 +1,12 @@
 import React from "react"
 import { useHistory, useLocation } from "react-router-dom"
-import { Tab, Tabs, TabPanel, TabList, Container } from "juno-ui-components"
+import {
+  Tab,
+  Tabs,
+  TabPanel,
+  TabList,
+  Container,
+} from "@cloudoperators/juno-ui-components"
 
 const TabsComponent = ({ tabsConfig, ...otherProps }) => {
   const location = useLocation()

lib/generators/templates/juno/app/javascript/widgets/app/components/Welcome.jsx

@@ -1,6 +1,6 @@
 import React from "react"
 
-import { IntroBox } from "juno-ui-components"
+import { IntroBox } from "@cloudoperators/juno-ui-components"
 
 const Welcome = () => (
   <>