Fix crash when record field is empty (#24)

Nuckal777 · web-flow · commit 73679205c1e1 · 2025-03-06T15:36:31.000+01:00
diff --git a/controllers/record_controller.go b/controllers/record_controller.go
@@ -144,8 +144,8 @@ func (r *RecordReconciler) reconcileRecord(ctx context.Context, record *discov1.
 	}
 
 	records := strings.FieldsFunc(rec, splitFunc)
-	if rec := records; len(rec) > 0 {
-		records = rec
+	if len(records) == 0 {
+		return fmt.Errorf("record %s/%s has no records", record.Namespace, record.Name)
 	}
 
 	for _, host := range record.Spec.Hosts {

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,8 @@ func (r RecordReconciler) reconcileRecord(ctx context.Context, record discov1.`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`records := strings.FieldsFunc(rec, splitFunc)`
`147`		`- if rec := records; len(rec) > 0 {`
`148`		`- records = rec`
	`147`	`+ if len(records) == 0 {`
	`148`	`+ return fmt.Errorf("record %s/%s has no records", record.Namespace, record.Name)`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`for _, host := range record.Spec.Hosts {`