Skip to content

Tutorial Page sapui5-adaptation-change-variant.md Issue. TEST GREEN #23882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DevRelations3 opened this issue Mar 5, 2025 · 6 comments
Open
Assignees

Comments

@DevRelations3
Copy link

Tutorial issue found: https://github.com/sap-tutorials/Tutorials/blob/master/tutorials/sapui5-adaptation-change-variant/sapui5-adaptation-change-variant.md contains invalid tags. Even though your tutorial was created, the invalid tags listed below were disregarded. Please double-check the following tags:

  • software-product>sap-s-4hana-public-cloud

Affected server: TEST GREEN

@rbrainey
Copy link
Contributor

rbrainey commented Mar 6, 2025

Current owner assigned. Please review.

@hitesh-parmar
Copy link
Contributor

@DevRelations3 I checked the assigned tags and noticed that the sap-s-4hana-public-cloud tag is not displayed on the website. Is this the problem? The tags that are currently visible are functioning correctly.

@rbrainey I observed a minor UI issue. Could you please report this to the development team? There is currently no space between the tags, which makes it a bit difficult for users to navigate.

Image

@hitesh-parmar
Copy link
Contributor

@rbrainey
Copy link
Contributor

For whatever reason, the tag should be "software-product>sap-s-4hana-cloud-public-edition". (note the -edition suffix).

@hitesh-parmar
Copy link
Contributor

hitesh-parmar commented Mar 18, 2025

@rbrainey Not sure if you saw my message here #23882 (comment)

You are right, but if you check my comment, how is it that the same tag without "edition" works for this tutorial? #23882 (comment)

@rbrainey
Copy link
Contributor

I realize SAP's use of commas in product names adds a bit of challenge here. The current version of the Markdown to HTML renderer adds a single space after the comma. Also, FWIW, tags will dynamically highlight with an underscore under the full tag when the user hovers over it. Beyond that, the spacing and punctuation choices originate from the SAP.com Semaphore team when creating each tag. Tutorial Markdown is converted to static HTML at the time that the MD file is committed. If there's an example tutorial that doesn't look rendered according to what I just described, it can be refreshed by committing a trivial change to the MD file.

Here are some of the valid variants for S/4HANA I see in the IMS Tag Browser:

id Title MD Format Taxonomy
0 SAP S 4HANA Cloud software-product>sap-s-4hana-cloud Software Product : Enterprise Management / SAP S 4HANA Cloud
1 SAP S 4HANA Cloud Private Edition software-product>sap-s-4hana-cloud-private-edition Software Product : Enterprise Management / SAP S 4HANA Cloud / SAP S 4HANA Cloud Private Edition
2 SAP S 4HANA Cloud Public Edition software-product>sap-s-4hana-cloud-public-edition Software Product : Enterprise Management / SAP S 4HANA Cloud / SAP S 4HANA Cloud Public Edition
3 SAP S 4HANA Cloud Public Edition, three-system landscape software-product>sap-s-4hana-cloud-public-edition--three-system-landscape Software Product : Enterprise Management / SAP S 4HANA Cloud Public Edition, three-system landscape

Any tags defined in that browser that have a defined "MD Format" will be valid tags for use in Tutorials. Beyond that, I cannot explain what's going on in the other tutorial. It's possible that the tag (software-product>sap-s-4hana-public-cloud) was valid when the tutorial was last committed and the Semaphore team subsequently made a change. I would not expect it to be valid when the Tutorial is committed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants