fix(cli): patch missing SYSTEMROOT env var on windows
#4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
binoy14
approved these changes
Feb 28, 2023
sindresorhus
reviewed
Mar 1, 2023
| * `process.env.SYSTEMROOT` is sometimes `undefined`, whereas `process.env.SystemRoot` is _NOT_. | ||
| * | ||
| * The `open` npm module uses the former to open a browser on Powershell, and Sindre seems | ||
| * unwilling to fix it (https://github.com/sindresorhus/open/pull/299#issuecomment-1447587598), |
There was a problem hiding this comment.
That's not what I said. I said I wanted to see an issue posted on Node.js first, so it can be properly fixed eventually. When that's done, I'm happy to merge the workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
openmodule tries to use theSYSTEMROOTenvironment variable on Windows, which seems to (sometimes?) not exist. Some backgrounds here: sindresorhus/open#299Sindre seems unwilling to fix in the
openmodule, so I figure we might as well implement a workaround for it since it currently causes issues for onboarding of new users on Windows (theloginaction will fail when attempting to open a browser).Fixes #4195
Fixes #4194
[sc-30570]
What to review
Notes for release