General feedback #3334
Replies: 11 comments 17 replies
-
|
There's a use case I have been thinking about for a while, which seems to be far closer within reach now: Having some Sanity-powered forms embedded into a sidebar of a site, shown only when an admin is logged in. Sure, it would go a bit against the pure headless nature of Sanity, but it would make some things much easier when content is shown in its context. While Studio offers preview integration and side-by-side panes for this, I would be interested in showing individual documents without the full Studio UI and Structure navigation. Perhaps there can be some config options to the announced I have seen https://github.com/sanity-io/sanity/blob/next/packages/%40sanity/form-builder/docs/quickstart.md which is deprecated/legacy documentation that shows exactly what I would like to have available. This would be the lowest level approach. A bit more high level to deal with changes (and document creation for example) would certainly be welcome. |
Beta Was this translation helpful? Give feedback.
-
|
Does something like this work? https://www.youtube.com/watch?v=298mlqa1-Hk Check it out at the 6 min mark. |
Beta Was this translation helpful? Give feedback.
-
|
It might, but right now the UI that is embedded is the full Studio setup (navbars, sidebar, panes, etc.). I would prefer the ability to create a single document form as a React component (or better yet, like |
Beta Was this translation helpful? Give feedback.
-
|
Great work on this release. I had trouble finding much information about integrating into an existing Next.js app. Are there any docs that cover this? |
Beta Was this translation helpful? Give feedback.
-
|
This might help as well: |
Beta Was this translation helpful? Give feedback.
-
|
We'll write a tutorial for it real soon! |
Beta Was this translation helpful? Give feedback.
-
|
@kmelve overall this works great. How do you all recommend handling the Studio routing in a Next.js app. Hard refreshes and deep links will 404 so you must make the request to the basePath. Also, Vercel unique preview deploy URLs are blocked by CORS settings and I haven't yet found a way to best handle. |
Beta Was this translation helpful? Give feedback.
-
|
Make sure that you use an optional catch all route, so that all requests go to the Studio component. For the CORS settings, you can add one with a wildcard. I believe Vercel gives you a scoped preview URL so you can add something like |
Beta Was this translation helpful? Give feedback.
-
|
Thx, made some updates and now works great 🙌🏻 |
Beta Was this translation helpful? Give feedback.
-
|
Typescript suggestion I'm migrating some schemas over to V3 and love the type safety, but am having issues correctly migrating document previews. Here is what I have to do to avoid typescript errors: import { formatRelative } from "date-fns";
import { SchemaTypeDefinition } from "sanity";
function selectTopic(topics: unknown[]) {
const currentTopic = topics[topics.length - 1];
if (currentTopic && typeof currentTopic === "object") {
const title = "title" in currentTopic ? (currentTopic["title"] as string) : undefined;
const category = "category" in currentTopic ? (currentTopic["category"] as string) : undefined;
const twitchCategory = "twitchCategory" in currentTopic ? (currentTopic["twitchCategory"] as string) : undefined;
return [title, category, twitchCategory].filter((x) => !!x).join(" · ");
}
return "No topic";
}
export const LivestreamDocumentSchema: SchemaTypeDefinition = {
title: "Livestream",
name: "livestream",
type: "document",
fields: [
{
title: "Started At",
name: "timeStart",
type: "datetime",
initialValue: () => new Date().toISOString(),
validation: (Rule) => Rule.required(),
},
{
title: "Topics",
name: "topics",
type: "array",
of: [{ type: "streamTopic" }],
initialValue: [],
validation: (Rule) => Rule.min(1),
},
],
preview: {
select: {
topics: "topics",
timeStart: "timeStart",
},
prepare({ topics, timeStart: rawTimeStart }) {
const title = selectTopic(topics as []);
const timeStart = typeof rawTimeStart === "string" || typeof rawTimeStart === "number" ? rawTimeStart || "" : "";
const startAt = formatRelative(new Date(timeStart || ""), new Date());
const subtitle = startAt.toLocaleUpperCase();
return { title, subtitle };
},
},
};What would make more sense to me is if I could pass a Generic to the prepare function like so: export const LivestreamDocumentSchema: SchemaTypeDefinition = {
// removed for brevity
preview: {
select: {
topics: "topics",
timeStart: "timeStart",
},
prepare<{ topics: [], timeStart:string }>({ topics, timeStart }) {
const currentTopic = topics[topics.length - 1];
const title = [title, category, twitchCategory].filter((x) => !!x).join(" · ");
const startAt = formatRelative(new Date(timeStart || ""), new Date());
const subtitle = startAt.toLocaleUpperCase();
return { title, subtitle };
},
},
}; |
Beta Was this translation helpful? Give feedback.
-
|
That's a great suggestion! Maybe we can use this generic to also get a better type definition for the preview component 🤔 Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Tiny, tiny Typescript issue: field's type definition don't support interface BaseDefinitionOptions {
// ...
validation?: (rule: Rule) => Rule
PS: should I report these somewhere else? |
Beta Was this translation helpful? Give feedback.
-
|
I don't know where to post this but I thought I'd let you guys know that with the latest dev build, we get
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
What could I be missing here? This is in a Next.js app setup and I can't see the Desk in studio running development mode
|
Beta Was this translation helpful? Give feedback.
-
|
Hey, Nice work on the v3. Il really love the fact that you used Vite, it is going to make the dev experience so much faster! First of all, I do not get why you added an other level of information for slugs: "Current slug". And at least, I hope this is going to be editable :-). French editors do not understand the word "slug", so this might not help their editing experience. Oh and we lost the "generate" button, or I missed it somewhere?
Secondly, why is there a level indentation (fieldset line) for single inputs like a block or array (or even the slug input)? I get it when we need to group multiple fields together, for readability. But for single elements, it might be overkill, don't you think? Thank's again for all the work you are doing! |
Beta Was this translation helpful? Give feedback.
-
|
100% this on on the indentation. |
Beta Was this translation helpful? Give feedback.
-
|
The indentation and always visible title has been bugging me for quite a while. I created a workaround using a custom Field wrapper and some css trickery, but it would be great to have more options for display purposes. |
Beta Was this translation helpful? Give feedback.
-
|
So, because there are so many hours in a day, let me outsource some thoughts for expanding Sanity's capabilities. Hopefully, a kind-hearted developer who shares these visions will pick up these breadcrumbs and bring these features into existence. 🙏🤞 v3 Studio ideas:
General Sanity platform ideas:
Those are the main things I can think of for now. If I come up with more, I'll let everyone know. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Not me trying to implement idea 5 into my v2 studio 🥲, I really hope that feature gets added. Preferably along with a way to add to the studio’s header for studio specific icons, webmanifest and ect. |
Beta Was this translation helpful? Give feedback.
-
|
I've been working with V3 for 2.5 weeks now, I'm beyond excited for it! Tons of new architectural patterns and editorial improvements that were impossible before - thank you for the work on this 😄 Here's what I've gathered so far: Feature requests
Bugs & odditiesI imagine you know about most of these and hence why it's a dev preview and not a production-ready version 🙃
Let me know if I should consolidate this elsewhere - glad to help however I can! |
Beta Was this translation helpful? Give feedback.
-
|
Hi! Testing out the new v3 for the first time, and I'm loving it so far. Here's a few things I'd love for you to consider moving forward: Remove prettier configThe files generated with Sanity's CLI includes a customized Prettier setup. I suggest you skip that, and instead opt in to the default settings of Prettier. There is no reason for why you want to add these hightly subjective preferences to the boilerplate – just let people override them if they want. Stop using yarnNPM is the default tool for handling packages. Why not default to using that? Especially when I run the CLI bootstrapping script in a context of existing package-lock.json files etc – shouldn't it just use what's already there? Make TypeScript the defaultRight now, you have to opt-in of using TypeScript instead of opting out. This is contrary to what i.e. Remix does in their bootstrapping tool. TypeScript has become the defacto standard for developing these days, and changing the default to "yes" would be a step in the right direction Use React 18 by defaultIs there any reason whatsoever to not use React 18 out of the box when things are bootstrapped? –– Otherwise, I'd love a 1-to-1 migration guide for the most common packages. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback! Prettier config: Yeah, I agree. I'll forward this to the team. Stop using yarn: I believe the CLI should give a prompt on what package manager you prefer ( Make TypeScript the default: Yes, TypeScript has become more popular, and it might be getting to the point it's more “de facto,” but I'm not sure we're there quite yet? We have a lot of new learners coming to the platform as well, so that would be something we would need to think more deeply about. E.g. Next.js and Svelte have not gone TypeScript default (yet). Use React 18 by default: Yes, we're working on it! 1-to-1 migration guide What package are you thinking about? |
Beta Was this translation helpful? Give feedback.
-
Package manager preferences are not only highly subjective, but is often a team-based decision. Many people use yarn for its workspaces feature, pnpm has gained a lot of traction lately, and yes, many still prefer/use npm. The CLI should already detect whether or not you are inside of a yarn or pnpm workspace, and also looks for lockfiles to determine the preferred one if not. It also checks whether or not the preferred package manager (based on the mentioned algorithm) is installed before suggesting to use it. In non-interactive environments, it will automatically pick the preferred choice. |
Beta Was this translation helpful? Give feedback.
-
I think part of the responsibility we have as a community is to promote good choices. And defaulting to using TypeScript is one of those choices. If you're new, that's fine, you can still choose to omit types, but most people using your platform won't be novices - they'll be seasoned vets. My 2 cents, at least :)
I don't think I got that prompt :/
Oh I totally agree. Yarn has its merits for sure. But since this choice is so subjective, it should default to the simplest choice - the one that ships with Node. IMHO.
Oh, then I have a feature request - let the script check for a lock file a few levels up. We work in a monorepo, and ran the cli in the Also, let me apologize for my somewhat aggressive tone in my previous message. I love Sanity and the work you do too much for choosing those kinds of words. 🤗 |
Beta Was this translation helpful? Give feedback.
-
|
I guess this doesn't apply specifically to the v3 Studio, but not sure where else to add this feedback, so giving it a shot... 1. Third-Party AuthenticationWas using the CLI to create a new project, and logged in via GitHub, which I often do in other services. Turned out I accidentally created a new Sanity account, because my my actual account uses email+password. Would be great if you, like so many others, allowed me to add the alternative authentication methods to my existing account, so I can use either one. 2. 2FAI've started using 1Password, and it makes it much easier for me to set up 2FA authentication on services via their built-in OTA-feature. So I've been going through important accounts and enabling it everywhere. Came to Sanity, and seems you don't support any 2FA at all? Can't find anything about it under my Account Settings at least. An account with access to do so much, leak data, potential damage, and so on, it feels like Sanity should definitely have the option of enabling 2FA? |
Beta Was this translation helpful? Give feedback.
-
You can add your users to an organization and transfer the projects that way. I agree that it's a bit cumbersome, but it's doable if you need to. |
Beta Was this translation helpful? Give feedback.
-
Any piece of feedback for the Developer Preview of Sanity Studio v3 that doesn't fit in the other threads? Put it here!
Beta Was this translation helpful? Give feedback.
All reactions