-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Disable deploy button during build time #6
Comments
good idea! should we / can we help on this?
|
Bump, this would be really helpful! CC @rexxars |
I had the same problem just now, the button doesn't seem to indicate clearly that the click worked, so it can end up queuing more than one build. |
Thanks for suggesting this feature, we will keep it in mind! The complication today is that we don't poll for updates, since the badge takes care of displaying the deploy state. |
When I see the Netlify build logs from my clients, I see that they triggered multiple builds in a very short time span. For example, one of the websites takes about 2 minutes to build and the logs show something like 12:03, 12:05, 12:07.
I suspect that they click several times (by accident) on the deploy button, which queues up deploy commands.
From my testing, double-clicking the deploy button doesn't trigger two builds. However, after ~10 seconds, it will trigger a new build.
I propose to disable the deploy button right after clicking on it and to enable again at after the build has completed.
What do you think? Have you fellow devs run into a similar issue with clients?
The text was updated successfully, but these errors were encountered: