Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Order status #52

Open
saniales opened this issue Oct 11, 2018 · 2 comments
Open

Get Order status #52

saniales opened this issue Oct 11, 2018 · 2 comments
Assignees
Milestone

Comments

@saniales
Copy link
Owner

saniales commented Oct 11, 2018

The bot should be able to know order status (eg. if an order is still open or is closed)

@saniales saniales self-assigned this Oct 11, 2018
@saniales saniales added this to the v0.0.3-alpha milestone Nov 5, 2018
@slawo
Copy link
Contributor

slawo commented Jan 24, 2021

How would this work? Would you implement functions like GetOrders(markets []Market) ([]UserOrder, error)
Should the following be tagged?

  • trading type (spot, margin, p2p)
  • order id (an id which can be used to update/cancel an order)
  • buy/sell
  • market
    Some of this data can be redundant depending on how the interface is implemented. If we want to be able to retrieve all orders for example we would need all of these fields identify which orders are what.

@saniales
Copy link
Owner Author

saniales commented Jan 26, 2021

The issue is about order status only

But you can retrieve a full order from a market

func GetOrder(id string) (*environment.Order, error)

This should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants