Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to integrate with Docker (Dockerize) ? #121

Closed
kozld opened this issue Oct 26, 2022 · 3 comments
Closed

How to integrate with Docker (Dockerize) ? #121

kozld opened this issue Oct 26, 2022 · 3 comments
Assignees
Labels

Comments

@kozld
Copy link

kozld commented Oct 26, 2022

I think that it can maybe helpfully. What do you think?

@saniales
Copy link
Owner

Hello and thanks for asking

Are you thinking of a particular entry point integration or something generic would suit?

@saniales
Copy link
Owner

I thought about a generic Dockerized implementation

FROM go:latest as builder
ADD .
RUN go build -o /tmp/golang-crypto-trading-bot 

FROM scratch

ADD config.yaml ./config.yaml
COPY --from=builder /tmp/golang-crypto-trading-bot ./golang-crypto-trading-bot 

CMD ["golang-crypto-trading-bot"]

that should do it (I did not test it) @kozld

@saniales saniales self-assigned this Jul 26, 2023
@saniales
Copy link
Owner

saniales commented Jan 8, 2024

After careful thinking about this, the manual Dockerfile is a better solution for anyone implementing any bot based on this framework, ergo I would keep any Docker version out of this repo.

If anybody needs to dockerize a project, can use the Dockerfile I provided in the other comment.

@saniales saniales closed this as completed Jan 8, 2024
@saniales saniales pinned this issue Jan 8, 2024
@saniales saniales changed the title Why not integration with a Docker ? How to integrate with Docker (Dockerize) ? Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants