Merge pull request #4774 from sanger/depfu/update/rubocop-capybara-2.22.1

[ruby] Update rubocop-capybara 2.21.0 → 2.22.1 (minor)

Author: StephenHulme

.rubocop.yml

@@ -5,9 +5,9 @@ require:
   - test_prof/rubocop
   - rubocop-performance
   - rubocop-rails
-  - rubocop-capybara
   - rubocop-factory_bot
 plugins:
+  - rubocop-capybara
   - rubocop-rspec
   - rubocop-rspec_rails
 

Gemfile.lock

@@ -333,13 +333,14 @@ GEM
       racc (~> 1.4)
     ostruct (0.6.0)
     parallel (1.26.3)
-    parser (3.3.7.1)
+    parser (3.3.7.3)
       ast (~> 2.4.1)
       racc
     pp (0.6.2)
       prettyprint
     prettier_print (1.2.1)
     prettyprint (0.2.0)
+    prism (1.4.0)
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -463,21 +464,23 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.1)
-    rubocop (1.74.0)
+    rubocop (1.75.1)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.43.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.40.0)
-      parser (>= 3.3.1.0)
-    rubocop-capybara (2.21.0)
-      rubocop (~> 1.41)
+    rubocop-ast (1.43.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-capybara (2.22.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
     rubocop-factory_bot (2.26.1)
       rubocop (~> 1.61)
     rubocop-performance (1.22.1)

app/api/core/endpoint/basic_handler/actions.rb

@@ -59,7 +59,7 @@ def check_request_io_class!(request)
     raise StandardError, 'Need an I/O class for this request' if request.io.nil?
   end
 
-  def does_not_require_an_io_class
+  def not_require_an_io_class?
     singleton_class.class_eval('def check_request_io_class!(_) ; end', __FILE__, __LINE__)
   end
 

app/api/core/endpoint/basic_handler/actions/bound.rb

@@ -17,5 +17,5 @@ def bound_#{name}(name, *args, &block)
   end
 
   delegate_to_bound_handler :action_guard
-  delegate_to_bound_handler :action_does_not_require_an_io_class, :does_not_require_an_io_class
+  delegate_to_bound_handler :action_not_require_an_io_class?, :not_require_an_io_class?
 end

app/api/endpoints/uuids.rb

@@ -113,7 +113,7 @@ class << response
         'url' => request.service.api_path(uuid.external_id)
       }
     end
-    bound_action_does_not_require_an_io_class(:lookup)
+    bound_action_not_require_an_io_class?(:lookup)
 
     # Handles trying to find multiple resources
     bind_action(:create, to: 'bulk', as: :bulk) do |_, request, response|
@@ -135,6 +135,6 @@ class << response
         }
       end
     end
-    bound_action_does_not_require_an_io_class(:bulk)
+    bound_action_not_require_an_io_class?(:bulk)
   end
 end

app/models/state_changer/standard_plate.rb

@@ -66,9 +66,8 @@ def update_associated_requests
     # Check the request is not in other wells (excuding any in contents or that already have the target state)
     def request_in_other_wells(request)
       _receptacles.any? do |well|
-        well.aliquot_requests.try(:map, &:id).to_a.any?(request.id) &&
-          (contents.present? && contents.exclude?(well.absolute_position_name)) &&
-          well.state != associated_request_target_state
+        well.aliquot_requests.try(:map, &:id).to_a.any?(request.id) && contents.present? &&
+          contents.exclude?(well.absolute_position_name) && well.state != associated_request_target_state
       end
     end
 

spec/features/assets/asset_submission_spec.rb

@@ -191,6 +191,7 @@
     it 'the link is not visible' do
       login_user user
       visit labware_path(asset)
+      expect(page).to have_text("Labware #{asset.name}") # confirm page has loaded
       expect(page).to have_no_text('Request additional sequencing')
     end
   end

spec/features/batches/sort_requests_spec.rb

@@ -23,7 +23,7 @@
     # Suspect this is due to the quite specific locations at which the rows can be dropped.
     third_request.drag_to first_request
 
-    expect(request_list.all('tr').first).to eq(third_request)
+    expect(request_list.first('tr')).to eq(third_request)
 
     post_drag = [requests_ids[2], requests_ids[0], requests_ids[1]]
     Warren.handler.clear_messages

spec/features/patient_consent_withdrawl_spec.rb

@@ -135,6 +135,7 @@
     it 'and a user visit the sample show page' do
       login_user user
       visit sample_path(sample)
+      expect(page).to have_content sample.name # confirm page has loaded
       expect(page).to have_no_content 'Patient consent has been withdrawn for this sample'
     end
 

spec/features/shared_examples/cherrypicking.rb

@@ -114,7 +114,7 @@
 
             step 'get the file' do
               within('#output_assets table tbody') do
-                row = page.all('tr', text: /#{destination_barcode}/).first
+                row = page.first('tr', text: /#{destination_barcode}/)
                 within(row) { click_link 'Print worksheet' }
               end