-
Notifications
You must be signed in to change notification settings - Fork 6
Upgrade dependencies including Django -> 5.2 #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidfischer
merged 1 commit into
davidfischer/upgrade-python314
from
davidfischer/upgrade-django-52
Nov 1, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,10 @@ | |
| Django settings for pythonsd project. | ||
|
|
||
| For more information on this file, see | ||
| https://docs.djangoproject.com/en/4.2/topics/settings/ | ||
| https://docs.djangoproject.com/en/dev/topics/settings/ | ||
|
|
||
| For the full list of settings and their values, see | ||
| https://docs.djangoproject.com/en/4.2/ref/settings/ | ||
| https://docs.djangoproject.com/en/dev/ref/settings/ | ||
| """ | ||
|
|
||
| import json | ||
|
|
@@ -20,7 +20,7 @@ | |
|
|
||
|
|
||
| # Quick-start development settings - unsuitable for production | ||
| # https://docs.djangoproject.com/en/4.2/howto/deployment/checklist/ | ||
| # https://docs.djangoproject.com/en/dev/howto/deployment/checklist/ | ||
|
|
||
| # SECURITY WARNING: keep the secret key used in production secret! | ||
| # SECURITY WARNING: don't run with debug turned on in production! | ||
|
|
@@ -82,14 +82,14 @@ | |
|
|
||
|
|
||
| # Database | ||
| # https://docs.djangoproject.com/en/4.2/ref/settings/#databases | ||
| # https://docs.djangoproject.com/en/dev/ref/settings/#databases | ||
| # -------------------------------------------------------------------------- | ||
| DATABASES = {"default": dj_database_url.config(default="sqlite:///db.sqlite3")} | ||
| DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField" | ||
|
|
||
|
|
||
| # Internationalization | ||
| # https://docs.djangoproject.com/en/4.2/topics/i18n/ | ||
| # https://docs.djangoproject.com/en/dev/topics/i18n/ | ||
| # -------------------------------------------------------------------------- | ||
| LANGUAGE_CODE = "en-us" | ||
|
|
||
|
|
@@ -101,8 +101,8 @@ | |
|
|
||
|
|
||
| # Static files (CSS, JavaScript, Images) | ||
| # https://docs.djangoproject.com/en/4.2/howto/static-files/ | ||
| # https://docs.djangoproject.com/en/4.2/ref/settings/#std-setting-STORAGES | ||
| # https://docs.djangoproject.com/en/dev/howto/static-files/ | ||
| # https://docs.djangoproject.com/en/dev/ref/settings/#std-setting-STORAGES | ||
| # -------------------------------------------------------------------------- | ||
| STATIC_ROOT = os.path.join(BASE_DIR, "staticfiles") | ||
| STATIC_URL = "/static-files/" | ||
|
|
@@ -127,15 +127,15 @@ | |
|
|
||
|
|
||
| # https://docs.djangoproject.com/en/4.2/topics/email/ | ||
| # https://docs.djangoproject.com/en/dev/topics/email/ | ||
| # -------------------------------------------------------------------------- | ||
| EMAIL_BACKEND = "django.core.mail.backends.console.EmailBackend" | ||
| DEFAULT_FROM_EMAIL = "[email protected]" | ||
| SERVER_EMAIL = DEFAULT_FROM_EMAIL | ||
|
|
||
|
|
||
| # Caching | ||
| # https://docs.djangoproject.com/en/4.2/ref/settings/#caches | ||
| # https://docs.djangoproject.com/en/dev/ref/settings/#caches | ||
| # -------------------------------------------------------------------------- | ||
| CACHES = { | ||
| "default": { | ||
|
|
@@ -148,8 +148,8 @@ | |
| # A sample logging configuration. The only tangible logging | ||
| # performed by this configuration is to send an email to | ||
| # the site admins on every HTTP 500 error when DEBUG=False. | ||
| # http://docs.djangoproject.com/en/4.2/topics/logging | ||
| # https://docs.djangoproject.com/en/4.2/ref/settings/#logging | ||
| # http://docs.djangoproject.com/en/dev/topics/logging | ||
| # https://docs.djangoproject.com/en/dev/ref/settings/#logging | ||
| # -------------------------------------------------------------------------- | ||
| LOGGING = { | ||
| "version": 1, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,20 @@ | ||
| -r common.txt | ||
|
|
||
| # Used for code formatting | ||
| black==24.4.2 | ||
| pre-commit==3.7.1 | ||
| black==25.9.0 | ||
| pre-commit==4.3.0 | ||
|
|
||
| # Used for code coverage | ||
| coverage==7.5.1 | ||
| django_coverage_plugin==3.1.0 | ||
| coverage==7.11.0 | ||
| django_coverage_plugin==3.2.0 | ||
|
|
||
| # Used in local testing | ||
| WebTest==3.0.0 | ||
| beautifulsoup4==4.12.3 | ||
| WebTest==3.0.7 | ||
| beautifulsoup4==4.14.2 | ||
| WebOb==1.8.9 | ||
| responses==0.25.0 | ||
| responses==0.25.8 | ||
|
|
||
| # Used to help with Django related debugging | ||
| django-debug-toolbar==4.3.0 | ||
| django-debug-toolbar==6.0.0 | ||
|
|
||
| tox>=4.0,<5.0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very, very small nit: It seems that the links point to the development version of the docs. Not sure if this is intended? Definitely would block merging because of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I upgraded the docs links to the dev version on purpose so I don't have to update ~20 comments when we do a Django update. Do you think we should explicitly point to the 5.2 docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with leaving them pointing to the dev version, as long as we know why.