New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awesome list preperation #12
Comments
Awesome-lint runFixed various issues. Many issues still remain but are invalid. Examples:
|
So, the only thing missing is the 2nd PR review, is that correct? |
Yes, I think so 🙂 |
The guidelines have the following statement regarding the table of contents: "Should only have one level of nested lists, preferably none." Maybe we should remove the link to the top heading so we can shift up everything in the list. |
Actually, that limitation would also cause problem with the "Data Formats" as well. If we follow the guidelines, JSON, CSV and XML would need to |
Also, if you need some inspirations for a review, it seems like the recent PR named "Add Google Cloud" failed to apply the following rule (last 2 sentences):
Basically, the contributing link should be in a seperate section named "Contributing" (not a subsection) and the section "About This Document" shouldn't be part of the Table of Contents and renamed to "Footnotes" based on the next section of the guildelines. |
Also iirc I think I held off applying because of the symbology. I think the symbology is theoretically not allowed... |
It would be allowed at the end in the Footnotes section. Considering that the icons have a tooltip when hovering on them, I personally would mind putting the symbology at the end if that means that the list becomes eligible. There's always the option to ask for an exception, but I doubt that we'd get it. |
PR Requirements
PR Title: "Add VBA"
PR addition: "VBA/VB6 - Visual Basic for Applications (VBA) is an implementation of Microsoft's event-driven programming language Visual Basic 6.0 (VB6) built into most desktop Microsoft Office applications"
*Add to bottom of category, (not alphabetical order)
Author requirements
Requirments
The text was updated successfully, but these errors were encountered: