-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of magic numbers #16
Comments
It's worth mentioning that there are also a bunch of constants that are "declared" but that are copied across many different files and modules. Ultimately these should be de-duped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems like c2rust has removed a lot of the named constants so we've ended up with a bunch of magic numbers which are a lot less readable.
A good example might dumpkmap which has the following on line 77:
Versus the busybox version:
If and when someone gets
c2rust refactor
going this might be something good to tackle.The text was updated successfully, but these errors were encountered: