Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

conn.Close is not Idempotent #148

Open
ganesh-karthick opened this issue Nov 18, 2016 · 1 comment · May be fixed by #183
Open

conn.Close is not Idempotent #148

ganesh-karthick opened this issue Nov 18, 2016 · 1 comment · May be fixed by #183

Comments

@ganesh-karthick
Copy link

ganesh-karthick commented Nov 18, 2016 •
edited
Loading

API conn.Close()
Calling conn.Close on already closed connection causes program to panic, It would be good, if the call is made idempotent.

goroutine 8 [running]:
panic(0x576420, 0xc420252880)
	Documents/devtools/go/src/runtime/panic.go:500 +0x1a1
/github.com/samuel/go-zookeeper/zk.(*Conn).Close(0xc4203ea000)
	/home/Documents/git/goworkspace/src/github.com/samuel/go-zookeeper/zk/conn.go:253 +0x47
@mattn
Copy link

mattn commented Jul 3, 2017

any update on this? conn.Close() is not atomic even though most of APIs are goroutine safe.

@jdef jdef linked a pull request Jan 13, 2018 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

idempotent Close; queueRequest guards against deadlocks on closed connections jdef/go-zookeeper
2 participants
@mattn @ganesh-karthick