extended light source (Sun) with multi-threading + other minor updates to thermal model for spinup #64
Conversation
|
I skimmed it quickly. It looks like it includes a lot of changes to gerlache. I guess these are just the things you've been working on for your latest plots? Either way, looks good. Please go and merge. |
|
Yes, it includes the changes to gerlache for running the model over a full year and eventually spinning it up (that's anyway an additional script w.r.t. the equilibrium temperature ones). But also, yes, there are some modifications to |
|
Oki, thanks! I hope most of it will be useful (should we "rebase and merge" or "squash and merge", the latter reducing the whole thing to a single commit? Just in case there is a preference - edit: I opted for the former hoping it would be more readable, but already regret it a bit ^^) |
|
I have been doing squash and merge, typically, but I haven't thought about which is preferable too much... |
|
Ops, sorry then, I'll keep it in mind (also, I'll try to make smaller and more focused pull requests...).
-------- Messaggio originale --------Da: Sam Potter ***@***.***> Data: 22/04/22 12:18 PM (GMT-05:00) A: sampotter/python-flux ***@***.***> Cc: Stefano Bertone ***@***.***>, State change ***@***.***> Oggetto: Re: [sampotter/python-flux] extended light source (Sun) with multi-threading + other minor updates to thermal model for spinup (PR #64)
I have been doing squash and merge, typically, but I haven't thought about which is preferable too much...
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
As from the title, this contains the extension and improvements that we discussed yesterday about using an extended light source (with multi-threading of CGAL aabb), correcting the orientation of the imported mesh (current master has it upside down in stereo + too many steps), and some extension of the thermal model interface useful for the spinup+extended source.
Might be useful to merge this while the 2 branches haven't diverged. ;)
Would close #51.