Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might need higher contrast in the code icon #917

Open
live627 opened this issue Jan 28, 2023 · 2 comments
Open

Might need higher contrast in the code icon #917

live627 opened this issue Jan 28, 2023 · 2 comments

Comments

@live627
Copy link
Collaborator

live627 commented Jan 28, 2023

I find myself always doing a double take when going for the code button. I would accidentally click the quote icon (it is adjacent).

For reference, the editor we were using before we discarded it in favor of sceditor had different icons that were more visually unique.
Screenshot 2023-01-27 at 17-22-42 Envision Portal - Modify Modules

The current buttons
Screenshot 2023-01-27 at 17-21-17 {{ n b b _b }}yesyes

The same iconset has a similar icon with higher contrast
Screenshot 2023-01-27 at 17-02-39 Code Icons - Download 63 Free Code icons here - Page 2
https://iconarchive.com/show/silk-icons-by-famfamfam/page-white-code-icon.html

Additionally, the Fugue icons has a good one (monochrome may be better for accessibility from color-blind people)
Screenshot 2023-01-27 at 16-32-35 Envision Portal - Modify Modules
https://iconarchive.com/show/fugue-icons-by-yusuke-kamiyamane/edit-code-icon.html

@samclarke
Copy link
Owner

Those icons are the famfamfam silk icons. If the code icon is changed, it would need to be the white icon or a custom icon otherwise we would need to look into adding attribution.

The famfamfam icons are not ideal. They were great back when the editor was created, but they lack retina support or other sizes. Someone did start making a retina version a while ago, but it was incomplete the last time I checked.

If SVGs are OK, using material or monocon icons would likely be better. They scale and are included inline so the colour can be changed with CSS if desired. They're also single colour (unless changed with CSS) so shouldn't have any colourblind accessibility issues.

Material:
Screenshot from 2023-01-28 16-02-30

Monocons:
Screenshot from 2023-01-28 16-02-40

@samclarke
Copy link
Owner

Found the retina version, sadly it's still incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants