From eb4214f4fe16feb0e83901b43459cb99489ea197 Mon Sep 17 00:00:00 2001 From: "zhuzhenfeng.code" Date: Fri, 7 Oct 2022 18:17:30 +0800 Subject: [PATCH 1/3] typo: doc Get not MustGet Change-Id: I1c5bce2c9e4057d0669a0c7dd5df81e39849f6f1 --- result.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/result.go b/result.go index ee707c0..fa0a3b3 100644 --- a/result.go +++ b/result.go @@ -61,7 +61,7 @@ func (r Result[T]) Error() error { return r.err } -// MustGet returns value and error. +// Get returns value and error. // Play: https://go.dev/play/p/8KyX3z6TuNo func (r Result[T]) Get() (T, error) { if r.isErr { From 0804f725065d1c536e9b780917f78b4c1af5aaa4 Mon Sep 17 00:00:00 2001 From: "zhuzhenfeng.code" Date: Fri, 7 Oct 2022 18:19:51 +0800 Subject: [PATCH 2/3] remove unused time.Now Change-Id: Ib2d617a6c20f6951559281796049615e7a0d9e1d --- option.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/option.go b/option.go index e9c5918..29bdaaa 100644 --- a/option.go +++ b/option.go @@ -8,7 +8,6 @@ import ( "errors" "fmt" "reflect" - "time" ) var optionNoSuchElement = fmt.Errorf("no such element") @@ -186,7 +185,6 @@ func (o *Option[T]) UnmarshalJSON(b []byte) error { } o.isPresent = true - time.Now() return nil } From e85639c683f9e16cab09878c1bce5d843a618394 Mon Sep 17 00:00:00 2001 From: "zhuzhenfeng.code" Date: Fri, 7 Oct 2022 18:24:42 +0800 Subject: [PATCH 3/3] fix some future doc typo Change-Id: Ic811f01a130863a81cde9e79c22a1fd8b025f1b4 --- future.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/future.go b/future.go index fba44ef..faf2345 100644 --- a/future.go +++ b/future.go @@ -46,7 +46,7 @@ func (f *Future[T]) reject(err error) { } } -// Catch is called when Future is resolved. It returns a new Future. +// Then is called when Future is resolved. It returns a new Future. func (f *Future[T]) Then(cb func(T) (T, error)) *Future[T] { f.mu.Lock() defer f.mu.Unlock() @@ -171,7 +171,7 @@ func (f *Future[T]) Result() Result[T] { return TupleToResult(f.Collect()) } -// Result wraps Collect and returns a Result. +// Either wraps Collect and returns a Either. func (f *Future[T]) Either() Either[error, T] { v, err := f.Collect() if err != nil {