{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":2606873,"defaultBranch":"master","name":"tough-cookie","ownerLogin":"salesforce","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2011-10-19T15:22:36.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/453694?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1719327426.0","currentOid":""},"activityList":{"items":[{"before":"9daadb2e74c794aeb7f20170ae737ec4a725510b","after":null,"ref":"refs/heads/update_contributors","pushedAt":"2024-06-25T14:57:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"colincasey","name":"Colin Casey","path":"/colincasey","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19131?s=80&v=4"}},{"before":"e485f17324ef1505f32d0121220f3e62f952f42d","after":"59626edc5c8e324a7a05d927398562fa7ae837a7","ref":"refs/heads/master","pushedAt":"2024-06-25T14:57:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"colincasey","name":"Colin Casey","path":"/colincasey","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19131?s=80&v=4"},"commit":{"message":"Update contributors (#425)","shortMessageHtmlLink":"Update contributors (#425)"}},{"before":"c1cde8a2f72079fdf21ed6b90a4c3cd7a7780e07","after":"9daadb2e74c794aeb7f20170ae737ec4a725510b","ref":"refs/heads/update_contributors","pushedAt":"2024-06-24T22:22:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"colincasey","name":"Colin Casey","path":"/colincasey","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19131?s=80&v=4"},"commit":{"message":"Merge branch 'master' into update_contributors","shortMessageHtmlLink":"Merge branch 'master' into update_contributors"}},{"before":"c76831f2abdb0c0eeab67d3db405e85188420fc0","after":null,"ref":"refs/heads/wjh/latest-ts","pushedAt":"2024-06-24T14:24:30.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"}},{"before":"da21d8f1394ea00a54d0e07d8d32903187113ba7","after":"e485f17324ef1505f32d0121220f3e62f952f42d","ref":"refs/heads/master","pushedAt":"2024-06-24T14:24:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"Use latest TypeScript version (#423)\n\n* bump typescript version and other deps\r\n\r\n* linter fixes due to better type inference\r\n\r\n* use latest eslint\r\n\r\n* downgrade eslint\r\n\r\nnpm i doesn't complain but npm ci does :\\\r\n\r\n* regenerate docs","shortMessageHtmlLink":"Use latest TypeScript version (#423)"}},{"before":null,"after":"c1cde8a2f72079fdf21ed6b90a4c3cd7a7780e07","ref":"refs/heads/update_contributors","pushedAt":"2024-06-23T20:12:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"colincasey","name":"Colin Casey","path":"/colincasey","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19131?s=80&v=4"},"commit":{"message":"Update contributors","shortMessageHtmlLink":"Update contributors"}},{"before":"ad4f2a4dc35ff3f68a0bf0e3e26952b48dd3c4ed","after":"ff124e62262ecfa36d0d81012eddf188c80f9b09","ref":"refs/heads/fix_validations_not_calling_callbacks","pushedAt":"2024-06-23T20:06:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"colincasey","name":"Colin Casey","path":"/colincasey","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19131?s=80&v=4"},"commit":{"message":"Fix incorrect test","shortMessageHtmlLink":"Fix incorrect test"}},{"before":null,"after":"ad4f2a4dc35ff3f68a0bf0e3e26952b48dd3c4ed","ref":"refs/heads/fix_validations_not_calling_callbacks","pushedAt":"2024-06-23T19:55:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"colincasey","name":"Colin Casey","path":"/colincasey","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19131?s=80&v=4"},"commit":{"message":"I noticed this issue while upgrading `tough-cookie` in `jsdom` which was causing their test suite to hang. There is a sneaky little bug around our internal validations where, in several methods that accept callbacks, our validations error out directly and never invoke the given callback with the error. This can lead to code that waits for a callback that will never complete. This also affects functions wrapped in `Sync` which leverage callbacks to capture their return values.\n\nThe affected methods were:\n- `getCookiesSync`\n- `getCookieString`\n- `getSetCookieStrings`\n- `serializeSync`\n- `serialize`\n- `setCookieSync`\n- `setCookie`\n- `getCookiesSync`\n- `getCookies`\n\nThere were also several validation errors hiding in support methods. These appear to be redundant since the type signatures present already do much of the validation. These have been removed from:\n- `checkSameSiteContext`\n- `isHostPrefixConditionMet`\n- `isSecurePrefixConditionMet`\n- `cookieCompare`\n- `formatDate`\n- `permutePath`","shortMessageHtmlLink":"I noticed this issue while upgrading tough-cookie in jsdom which …"}},{"before":"0b161b53bf9d8fdd1846a45de7ddaba0c70db0e2","after":"c76831f2abdb0c0eeab67d3db405e85188420fc0","ref":"refs/heads/wjh/latest-ts","pushedAt":"2024-06-21T20:47:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"regenerate docs","shortMessageHtmlLink":"regenerate docs"}},{"before":"e92c1e1a801e520a350b3906088cbb4116eeb407","after":"0b161b53bf9d8fdd1846a45de7ddaba0c70db0e2","ref":"refs/heads/wjh/latest-ts","pushedAt":"2024-06-21T17:42:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"downgrade eslint\n\nnpm i doesn't complain but npm ci does :\\","shortMessageHtmlLink":"downgrade eslint"}},{"before":null,"after":"e92c1e1a801e520a350b3906088cbb4116eeb407","ref":"refs/heads/wjh/latest-ts","pushedAt":"2024-06-21T16:45:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"use latest eslint","shortMessageHtmlLink":"use latest eslint"}},{"before":"0d4147e0515be5316376f11cf92b1ead875ee6d9","after":null,"ref":"refs/heads/wjh/deps","pushedAt":"2024-06-05T14:03:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"}},{"before":"68738dd260cea7a42f28897ba700314fb8f875c2","after":"da21d8f1394ea00a54d0e07d8d32903187113ba7","ref":"refs/heads/master","pushedAt":"2024-06-05T14:03:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"chore: update deps (#421)\n\n* chore: update deps\r\n\r\n* chore: downgrade eslint\r\n\r\n* why is CI broken?\r\n\r\n* try minor bumps only\r\n\r\n* fix lockfile","shortMessageHtmlLink":"chore: update deps (#421)"}},{"before":"a34d55fc00e8da2fee75821e5dbf4de947129267","after":"0d4147e0515be5316376f11cf92b1ead875ee6d9","ref":"refs/heads/wjh/deps","pushedAt":"2024-06-03T16:59:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"fix lockfile","shortMessageHtmlLink":"fix lockfile"}},{"before":"46c288e3b5d4f2cd862d5ffa49d021130739f15d","after":"a34d55fc00e8da2fee75821e5dbf4de947129267","ref":"refs/heads/wjh/deps","pushedAt":"2024-06-03T16:52:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"try minor bumps only","shortMessageHtmlLink":"try minor bumps only"}},{"before":"809b15b6e044cb69ff00fa291537cb77d386f744","after":"46c288e3b5d4f2cd862d5ffa49d021130739f15d","ref":"refs/heads/wjh/deps","pushedAt":"2024-06-03T16:47:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"why is CI broken?","shortMessageHtmlLink":"why is CI broken?"}},{"before":"a92c114ca98529bb2e7c1a982f0a3b38d2c6c516","after":"809b15b6e044cb69ff00fa291537cb77d386f744","ref":"refs/heads/wjh/deps","pushedAt":"2024-06-03T16:12:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"chore: downgrade eslint","shortMessageHtmlLink":"chore: downgrade eslint"}},{"before":"549f5993d780da6a3a374d41299b5bacd552a0f2","after":"a92c114ca98529bb2e7c1a982f0a3b38d2c6c516","ref":"refs/heads/wjh/deps","pushedAt":"2024-06-03T15:53:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"Merge branch 'master' into wjh/deps","shortMessageHtmlLink":"Merge branch 'master' into wjh/deps"}},{"before":"b1f8037f44d8d5f4f0a1059e8b0272a828e73163","after":null,"ref":"refs/heads/dependabot/npm_and_yarn/production-dependencies-56ade9f167","pushedAt":"2024-06-03T15:52:24.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"}},{"before":"84d3d54e3c7dfb2bd1933953db2d4a41e451d528","after":"68738dd260cea7a42f28897ba700314fb8f875c2","ref":"refs/heads/master","pushedAt":"2024-06-03T15:52:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"Bump tldts in the production-dependencies group across 1 directory (#420)\n\nBumps the production-dependencies group with 1 update in the / directory: [tldts](https://github.com/remusao/tldts).\r\n\r\n\r\nUpdates `tldts` from 6.1.18 to 6.1.24\r\n- [Release notes](https://github.com/remusao/tldts/releases)\r\n- [Changelog](https://github.com/remusao/tldts/blob/master/CHANGELOG.md)\r\n- [Commits](https://github.com/remusao/tldts/compare/v6.1.18...v6.1.24)\r\n\r\n---\r\nupdated-dependencies:\r\n- dependency-name: tldts\r\n dependency-type: direct:production\r\n update-type: version-update:semver-patch\r\n dependency-group: production-dependencies\r\n...\r\n\r\nSigned-off-by: dependabot[bot] \r\nCo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>","shortMessageHtmlLink":"Bump tldts in the production-dependencies group across 1 directory (#420"}},{"before":null,"after":"549f5993d780da6a3a374d41299b5bacd552a0f2","ref":"refs/heads/wjh/deps","pushedAt":"2024-06-03T15:51:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"chore: update deps","shortMessageHtmlLink":"chore: update deps"}},{"before":"84af3e576473f97896b8b1a32eeec12dd2e09e2c","after":null,"ref":"refs/heads/dependabot/npm_and_yarn/production-dependencies-c74a397637","pushedAt":"2024-06-03T15:46:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"2c19da4df9296fd7cabd4de7e245fe70a09c2faa","after":null,"ref":"refs/heads/dependabot/npm_and_yarn/globals-15.3.0","pushedAt":"2024-06-03T15:45:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"5603aa44043171fa6c92fa135900283556ccf9d8","after":"84af3e576473f97896b8b1a32eeec12dd2e09e2c","ref":"refs/heads/dependabot/npm_and_yarn/production-dependencies-c74a397637","pushedAt":"2024-06-03T15:40:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"Merge branch 'master' into dependabot/npm_and_yarn/production-dependencies-c74a397637","shortMessageHtmlLink":"Merge branch 'master' into dependabot/npm_and_yarn/production-depende…"}},{"before":"d884d96f3543db3755e543684923e699434e44a6","after":"b1f8037f44d8d5f4f0a1059e8b0272a828e73163","ref":"refs/heads/dependabot/npm_and_yarn/production-dependencies-56ade9f167","pushedAt":"2024-06-03T15:40:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump tldts in the production-dependencies group across 1 directory\n\nBumps the production-dependencies group with 1 update in the / directory: [tldts](https://github.com/remusao/tldts).\n\n\nUpdates `tldts` from 6.1.18 to 6.1.24\n- [Release notes](https://github.com/remusao/tldts/releases)\n- [Changelog](https://github.com/remusao/tldts/blob/master/CHANGELOG.md)\n- [Commits](https://github.com/remusao/tldts/compare/v6.1.18...v6.1.24)\n\n---\nupdated-dependencies:\n- dependency-name: tldts\n dependency-type: direct:production\n update-type: version-update:semver-patch\n dependency-group: production-dependencies\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump tldts in the production-dependencies group across 1 directory"}},{"before":"4c02f71b991acf0bf1d2a40b554f209ccef28057","after":"2c19da4df9296fd7cabd4de7e245fe70a09c2faa","ref":"refs/heads/dependabot/npm_and_yarn/globals-15.3.0","pushedAt":"2024-06-03T15:40:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump globals from 14.0.0 to 15.3.0\n\nBumps [globals](https://github.com/sindresorhus/globals) from 14.0.0 to 15.3.0.\n- [Release notes](https://github.com/sindresorhus/globals/releases)\n- [Commits](https://github.com/sindresorhus/globals/compare/v14.0.0...v15.3.0)\n\n---\nupdated-dependencies:\n- dependency-name: globals\n dependency-type: direct:development\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump globals from 14.0.0 to 15.3.0"}},{"before":"ad8c543d16a8ea94e3d805c9f0137a3b887e15ca","after":null,"ref":"refs/heads/dependabot/npm_and_yarn/eslint/js-9.4.0","pushedAt":"2024-06-03T15:39:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"ebb4856669e7c694e08be88131f40bf75727452d","after":"84d3d54e3c7dfb2bd1933953db2d4a41e451d528","ref":"refs/heads/master","pushedAt":"2024-06-03T15:39:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"wjhsf","name":"Will Harney","path":"/wjhsf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62956339?s=80&v=4"},"commit":{"message":"Bump @eslint/js from 8.57.0 to 9.4.0 (#419)\n\nBumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 8.57.0 to 9.4.0.\r\n- [Release notes](https://github.com/eslint/eslint/releases)\r\n- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)\r\n- [Commits](https://github.com/eslint/eslint/commits/v9.4.0/packages/js)\r\n\r\n---\r\nupdated-dependencies:\r\n- dependency-name: \"@eslint/js\"\r\n dependency-type: direct:development\r\n update-type: version-update:semver-major\r\n...\r\n\r\nSigned-off-by: dependabot[bot] \r\nCo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>","shortMessageHtmlLink":"Bump @eslint/js from 8.57.0 to 9.4.0 (#419)"}},{"before":"d285046ca93e94036e359346549dee6b9402cbed","after":"4c02f71b991acf0bf1d2a40b554f209ccef28057","ref":"refs/heads/dependabot/npm_and_yarn/globals-15.3.0","pushedAt":"2024-06-03T15:38:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump globals from 14.0.0 to 15.3.0\n\nBumps [globals](https://github.com/sindresorhus/globals) from 14.0.0 to 15.3.0.\n- [Release notes](https://github.com/sindresorhus/globals/releases)\n- [Commits](https://github.com/sindresorhus/globals/compare/v14.0.0...v15.3.0)\n\n---\nupdated-dependencies:\n- dependency-name: globals\n dependency-type: direct:development\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump globals from 14.0.0 to 15.3.0"}},{"before":"57b2395a65fd527d35b12e21deb40c42773af357","after":"ad8c543d16a8ea94e3d805c9f0137a3b887e15ca","ref":"refs/heads/dependabot/npm_and_yarn/eslint/js-9.4.0","pushedAt":"2024-06-03T15:38:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump @eslint/js from 8.57.0 to 9.4.0\n\nBumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 8.57.0 to 9.4.0.\n- [Release notes](https://github.com/eslint/eslint/releases)\n- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/eslint/eslint/commits/v9.4.0/packages/js)\n\n---\nupdated-dependencies:\n- dependency-name: \"@eslint/js\"\n dependency-type: direct:development\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump @eslint/js from 8.57.0 to 9.4.0"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEbsIg7wA","startCursor":null,"endCursor":null}},"title":"Activity · salesforce/tough-cookie"}