Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

[SIDELINE] Cleanup PersistenceAdapter.persistSidelineRequestState() #75

Open
stanlemon opened this issue Nov 22, 2017 · 0 comments
Open

Comments

@stanlemon
Copy link
Contributor

  • The 'id' is included in the 'request' already, this is an artifact from the past - we should remove it outright.
  • The 'type' could be moved into the 'request', which probably makes more sense anyhow.
  • ConsumerPartition + offsets could be grouped together in a single ConsumerState object, this would move blowing up and persisting by partition into the persistence adapter, but should not functionally change anything. It'll cleanup the logic in the handler quite a bit too, and probably makes more sense in the adapter anyhow since the reason we do it the way we do is very specific for Zookeeper.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant