Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ESM and rely on a single lwc package #366

Closed
nolanlawson opened this issue Apr 18, 2024 · 2 comments
Closed

Convert to ESM and rely on a single lwc package #366

nolanlawson opened this issue Apr 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nolanlawson
Copy link
Contributor

This would be the first step to achieving #349. We should not have multiple @lwc/* package dependencies, but rather a top-level lwc dependency, and do our imports like this:

import compiler from 'lwc/compiler'

This requires converting from CommonJS to ESM.

@nolanlawson nolanlawson added the enhancement New feature or request label Apr 18, 2024
@nolanlawson
Copy link
Contributor Author

This would require our own consumers to use ESM. Although maybe it will be possible in future versions of Node: https://joyeecheung.github.io/blog/2024/03/18/require-esm-in-node-js/

@nolanlawson
Copy link
Contributor Author

After discussion in #349 I'm not sure how valuable this would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant