-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node:
protocol for all builtin imports (fs
, path
, etc.)
#4149
Labels
Comments
nolanlawson
added
Up for grabs
Issues that are relatively small, self-contained, and ready for implementation
enhancement
labels
Apr 15, 2024
This was referenced Apr 15, 2024
nolanlawson
removed
the
Up for grabs
Issues that are relatively small, self-contained, and ready for implementation
label
Apr 15, 2024
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should use an ESLint plugin like
prefer-node-protocol
and ensure we're always doing this:instead of this:
The
node:
protocol is clearer, more portable, and less likely to conflict with any accidental non-builtins (e.g.assert
).This has some mild Node compat issues, but since we probably only support Node 16+ anyway, we can probably safely do this. (Or we can do this in a major version bump and then be explicit about our supported Node version.)
The text was updated successfully, but these errors were encountered: