Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

loss computation in splitcross.py is false #82

Open
adjidieng opened this issue Nov 18, 2018 · 0 comments
Open

loss computation in splitcross.py is false #82

adjidieng opened this issue Nov 18, 2018 · 0 comments

Comments

@adjidieng
Copy link

adjidieng commented Nov 18, 2018

Hi,

Your code for adaptive softmax in splitcross.py is false.

(1) For the tail, you are taking log_softmax twice and you are accounting for p(tombstone) twice. You are getting the entropy both in self.log_prob() and inside the forward function.

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant