Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

スキーマ定義をする #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

スキーマ定義をする #10

wants to merge 3 commits into from

Conversation

batora9
Copy link

@batora9 batora9 commented Dec 11, 2024

あっているかよくわかりません！

@batora9 batora9 requested a review from Daaaai0809 December 11, 2024 03:05
@batora9 batora9 linked an issue Dec 11, 2024 that may be closed by this pull request
/ws/${channelId}のスキーマ定義 #5
Open
@batora9 batora9 requested a review from sor4chi December 11, 2024 03:06
Daaaai0809
Daaaai0809 requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Daaaai0809 Daaaai0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responseは悪くないけど、APIの定義なくない？？

proto/schema/response/websocket_api.proto Outdated Show resolved Hide resolved
@batora9 batora9 requested a review from Daaaai0809 January 9, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sor4chi sor4chi Awaiting requested review from sor4chi

@Daaaai0809 Daaaai0809 Awaiting requested review from Daaaai0809

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/ws/${channelId}のスキーマ定義
2 participants
@batora9 @Daaaai0809