feat: add delete to internal storage module (#45)

Author: ayoubfaouzi

internal/storage/local/local.go

@@ -99,3 +99,16 @@ func (s Service) Exists(ctx context.Context, bucketName, key string) (bool, erro
 func (s Service) GeneratePresignedURL(ctx context.Context, bucketName, key string) (string, error) {
 	return "", errors.New("not implemented")
 }
+
+// Delete deletes an object from the local file system.
+func (s Service) Delete(ctx context.Context, bucket, key string) error {
+
+	// Get the file path.
+	name := filepath.Join(s.root, bucket, key)
+	err := os.Remove(name)
+	if err != nil {
+		return err
+	}
+
+	return nil
+}

internal/storage/minio/minio.go

@@ -43,7 +43,7 @@ func New(endpoint, accessKey, secretKey string) (Service, error) {
 	return Service{s3Client}, nil
 }
 
-// Upload uploads an object to s3.
+// Upload uploads an object to the remote storage,.
 func (s Service) Upload(ctx context.Context, bucket, key string,
 	file io.Reader) error {
 
@@ -134,3 +134,16 @@ func (s Service) GeneratePresignedURL(ctx context.Context, bucketName,
 	}
 	return presignedURL.String(), nil
 }
+
+// Delete deletes an object from the remote storage.
+func (s Service) Delete(ctx context.Context, bucket, key string) error {
+
+	opts := mio.RemoveObjectOptions{}
+
+	err := s.client.RemoveObject(ctx, bucket, key, opts)
+	if err != nil {
+		return err
+	}
+
+	return nil
+}

internal/storage/s3/s3.go

@@ -6,14 +6,15 @@ package s3
 
 import (
 	"context"
+	"io"
+	"time"
+
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/aws/awserr"
 	"github.com/aws/aws-sdk-go/aws/credentials"
 	"github.com/aws/aws-sdk-go/aws/session"
 	awss3 "github.com/aws/aws-sdk-go/service/s3"
 	"github.com/aws/aws-sdk-go/service/s3/s3manager"
-	"io"
-	"time"
 )
 
 // Service provides abstraction to cloud object storage.
@@ -64,6 +65,7 @@ func New(region, accessKey, secretKey string) (Service, error) {
 	// Create a downloader with S3 client and custom options
 	downloader := s3manager.NewDownloaderWithClient(s3Svc,
 		func(u *s3manager.Downloader) {
+			u.Concurrency = 1            // Guarantee sequential writes
 			u.PartSize = 5 * 1024 * 1024 // 5MB per part
 		})
 
@@ -169,3 +171,20 @@ func (s Service) GeneratePresignedURL(ctx context.Context, bucketName, key strin
 
 	return urlStr, nil
 }
+
+// Delete removes an object from the store.
+func (s Service) Delete(ctx context.Context, bucket, key string) (bool, error) {
+
+	// Prepare the delete object input.
+	input := &awss3.DeleteObjectInput{
+		Bucket: aws.String(bucket),
+		Key:    aws.String(key),
+	}
+
+	_, err := s.s3svc.DeleteObjectWithContext(ctx, input)
+	if err != nil {
+		return false, err
+	}
+
+	return true, nil
+}