-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation fails with solc 0.8.23 #735
Comments
Running with compiler version In the release note of
Based on the documentation, it seems we need to pass the path:
But that results in compiling issues with |
Might be worth, once resolving, adding a CI job that compiles with the latest compiler and optimisations so that we don’t regress on this. |
This PR: - Fix the benchmark CI job to prebent regressions like #735. It is fixed by removing the OR operator because if a benchmark failed, it only outputted a message but didn't return a non-zero exit code. - Also bumps the `0.8.x` compiler version to the latest one (0.8.24)
@mmv08 so any solution for this issue yet? |
not yet, we use compiler v0.7.6 and this issue is a low priority for us |
Description
The project cannot be compiled with solc 0.8.23
Environment
Steps to reproduce
914d0f8fab0e8f73ef79581f6fbce86e34b049c3
(the latest one on the main branch at the moment of writing)npm i
cp .env.sample .env
SOLIDITY_VERSION='0.8.23'
npm run build
Additional context
The command output:
The text was updated successfully, but these errors were encountered: