-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] causes failures in GuardManager tests #436
Comments
farreldarian
pushed a commit
to farreldarian/safe-contracts
that referenced
this issue
Jan 14, 2024
…fe flow (safe-global#436) * fix(protocol-kit): fix standardizeSafeTransactionData for predictedSafe flow * removed Boolean casting in predictedSafe check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This doesn't really fit as either a feature or a bug; rather, it's more of a heads up. Note that with the release of
[email protected]
, a check was introduced ingetContractAt()
, which causes all test cases intest/core/GnosisSafe.GuardManager.spec.ts
to fail, as they all useAddressZero
as a parameter to the previously mentioned function.Please keep the issue open as we use it as a reference on the Solidity compiler team when we disable some externals cases, so that we can keep track of it, and hopefully re-enable said tests (or remove other restrictions) when this is fixed.
The text was updated successfully, but these errors were encountered: