Reenable styling of inline CSS #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I disabled this because #107 was causing widespread pain. CSS3 has so many syntax highlighting contexts that it was exceeding a hard limit of 25,000 contexts set by Sublime. This caused breakages of HTML, PHP, and any other language that embeds the HTML syntax (which embeds source.css). I made several failed attempts to fix this issue before finally giving up and disabling inline styling. Then, the issue magically went away somewhere around Sublime build 3209. I can't reproduce #107 anymore, so I'm going to try reenabling inline styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #131
I disabled inline styling because #107 was causing widespread pain. CSS3 has so many syntax highlighting contexts that it was exceeding a hard limit of 25,000 contexts set by Sublime. This caused breakages of HTML, PHP, and any other language that embeds the HTML syntax (which embeds source.css).
I made several failed attempts to fix this issue before finally giving up and disabling inline styling. Then, the issue magically went away somewhere around Sublime build 3209. I can't reproduce #107 anymore, so I'm going to try reenabling inline styling🤞😬