Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultGame.ini Updated with Every Build #2

Open
wildcarderw opened this issue Jul 7, 2023 · 1 comment
Open

DefaultGame.ini Updated with Every Build #2

wildcarderw opened this issue Jul 7, 2023 · 1 comment

Comments

@wildcarderw
Copy link

wildcarderw commented Jul 7, 2023

We are experiencing an issue with the latest updates to AgoraViewportClient whereby the DefaultGame.ini is modified every time a developer runs the editor. This isn't a desired behavior for us because we don't want developers committing DefaultGame.ini with every submission. This creates unnecessary history on this file and obscures meaningful changes.

The behavior occurs at this location.

void UAgoraViewportClientSettings::Internal_SetGit(FOnGitInfoUpdated OnGitInfoUpdated)
{
#if WITH_EDITOR
	static const auto IniFile = Get()->GetDefaultConfigFilename();
#else

To address this issue we perform an early return out of this function inside the WITH_EDITOR block. Recommend at least providing an option to disable this behavior, if not outright removing it.

@ryanjon2040
Copy link
Owner

Hey @wildcarderw

Please see issue #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants