Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISR: Ignore query params #1720

Closed
arsenasatryan opened this issue May 8, 2024 · 2 comments
Closed

ISR: Ignore query params #1720

arsenasatryan opened this issue May 8, 2024 · 2 comments

Comments

@arsenasatryan
Copy link

Problem Solved By The Feature

Sometimes it is required to use the same cached version even URL is not the same for particular 2 requests. for example, Google Search Ads adds a query parameter to the URL which is different for each request but the content of the page is the same

Solution

As a solution, it is possible to add a boolean that says to ignore query parameters for a route. additionally, there can be an array of query param names that can specified not to be ignored in case of query param based pagination for example.

@arsenasatryan arsenasatryan changed the title Ignore query params ISR: Ignore query params May 8, 2024
@SkyZeroZx
Copy link

I add to this both google ads, linkedin, facebook, etc. in some publication it adds a query param in front of it which could end up saturating the cache whether in the file system or redis or others.
It would be good to take it into account

@eneajaho
Copy link
Member

Hello @arsenasatryan
This was added in #1757 and will be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants