The request was not cached with FileSystemCacheHandler

[moaabd]

Description

when i use FileSystemCacheHandler and i want to cache a page with path like : /offre-emploi?salary=true.
I have an error Error: 💥 The request was not cached!
It work with simple path like : /offre-emploi but not with query param.

I try to use the default CacheHandler, and it work well.

const fsCacheHandler = new FileSystemCacheHandler({
cacheFolderPath: join(serverDistFolder, '/cache'),

    prerenderedPagesPath: serverDistFolder,
    addPrerenderedPagesToCache: false,
});

const isr = new ISRHandler({
    indexHtml,
    invalidateSecretToken: 'MY_TOKEN', // replace with env secret key ex. process.env.REVALIDATE_SECRET_TOKEN
    enableLogging: true,
    serverDistFolder,
    browserDistFolder,
    buildId: 'test',
    cache: fsCacheHandler,
    bootstrap: AppServerModule,
    commonEngine,skipCachingOnHttpError: false,
});

Expected

the page /offre-emploi?salary=true. must be cached like in InMemoryCacheHandler

Environment

SSR
Node: 20.9.0
Npm: 10.1.0
Angular: 17.0.3
Angular CLI: 17.0.1

Related to Other Issues

Tasks to Resolve This

Notes

[eneajaho]

Hello,
ISR doesn't support query params for the moment

This is the function that converts your route to filename and it only supports path params.
Can you rename this issue to:
feat: add support for query params in ISR FileSystemCacheHandler
Thanks.

rx-angular/libs/isr/server/src/cache-handlers/filesystem-cache-handler.ts

Line 342 in d94bb6b

function convertRouteToFileName(route: string): string {

[smartsuhani]

I've same issue regarding the cache handling, please take a look here, thanks.

[eneajaho]

I've same issue regarding the cache handling, please take a look here, thanks.

Hello @smartsuhani
Are you using the FilesystemCacheHandler? Are you passing query params in the URL? Is this the case?

[maxisam]

@eneajaho I add a commit to handle this one as well. Basically it just convert ? to "++" , we can use anything we like actually.