Skip to content
This repository has been archived by the owner on Jul 23, 2018. It is now read-only.

Need /healthz endpoint(s) #23

Open
ghost opened this issue Dec 22, 2017 · 1 comment
Open

Need /healthz endpoint(s) #23

ghost opened this issue Dec 22, 2017 · 1 comment
Assignees

Comments

@ghost
Copy link

ghost commented Dec 22, 2017

Hi.

I'm looking to deploy this via container to Kubernetes, where health checking of http endpoints is a manner of container life or death.

If Kubernetes can't get a 200 OK without polling vCenter API, using health checks with vmware_exporter could DoS vCenter API.

Could we get a /healthz endpoint (or two)?

  • 200 OK if web server is up. /healthz
  • 200 OK if vCenter API is up (without polling metrics). /healthz/api?vcenter.example.com

Edit: This is related:
https://stackoverflow.com/questions/43380939/where-does-the-convention-of-using-healthz-for-application-health-checks-come-f

Open to your thoughts.

Thanks for this awesome project!

-Joshua

@ghost ghost changed the title Need /health endpoint(s) Need /healthz endpoint(s) Dec 22, 2017
rverchere added a commit that referenced this issue Jan 30, 2018
@rverchere rverchere self-assigned this Jan 30, 2018
@rverchere
Copy link
Owner

Hello @josdotso,

I've just added /healthz endpoint, can you try it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant