chore: minor cleanup

Author: dpc

api/src/lib.rs

@@ -10,6 +10,7 @@ pub use self::net::*;
 
 mod log;
 pub use self::log::*;
+
 /// Logical offset in an the binary log stream
 ///
 /// Clients use this offset directly to traverse the log and

loglogd/src/node/segment_writer.rs

@@ -234,12 +234,7 @@ impl WriteLoopInner {
                 (next_segment_start_log_offset, new_segment)
             };
 
-            self.shared.put_entry_buffer(
-                new_segment.write_file_header(
-                    new_segment_start_log_offset,
-                    self.shared.pop_entry_buffer(),
-                ),
-            );
+            new_segment.write_file_header(new_segment_start_log_offset);
 
             // It would be tempting to just return the `new_segment` as the segment we need. But that would be
             // a mistake - this entry might theoretically be so far ahead, that it needs even more segments opened.

loglogd/src/segment.rs

@@ -1,4 +1,4 @@
-use crate::ioutil::{pwrite_all, vec_extend_to_at_least};
+use crate::ioutil::pwrite_all;
 use std::{
     fmt,
     fs::OpenOptions,
@@ -190,26 +190,23 @@ pub struct OpenSegment {
 }
 
 impl OpenSegment {
-    pub fn write_file_header(&self, log_offset: LogOffset, mut buf: Vec<u8>) -> Vec<u8> {
-        vec_extend_to_at_least(&mut buf, SegmentFileHeader::BYTE_SIZE);
+    pub fn write_file_header(&self, log_offset: LogOffset) {
+        let buf = [0u8; SegmentFileHeader::BYTE_SIZE];
 
         let header = SegmentFileHeader {
             version: 1,
             log_offset,
             ff_end: (),
         };
 
-        header
-            .write(&mut Cursor::new(&mut buf))
-            .expect("can't fail");
+        header.write(&mut Cursor::new(buf)).expect("can't fail");
 
         let res = pwrite_all(self.fd.as_raw_fd(), 0, &buf[..SegmentFileHeader::BYTE_SIZE]);
 
         if let Err(e) = res {
+            // We can't really tolerate errors when writting to log
             panic!("IO Error when writting log: {}, crashing immediately", e);
         }
-
-        buf
     }
 }