Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse_kdc_rep in krb5_parser.rs seems don't work properly. #9

Closed
hchsoon opened this issue Nov 13, 2021 · 2 comments
Closed

Parse_kdc_rep in krb5_parser.rs seems don't work properly. #9

hchsoon opened this issue Nov 13, 2021 · 2 comments

Comments

@hchsoon
Copy link

hchsoon commented Nov 13, 2021

Hey there, it occurred to me that some fields would not be properly extracted when padata, the optional field, is absent.
From my perspective, it could be caused by the unwrap_or_default function. If no padata found there , i, the remaining data here, would be empty as the default return value. Consequently, the following fields would never be parsed.

@chifflier
Copy link
Member

Good catch, thanks! I will check that there are no similar errors in the code, and push a commit to fix this.

@chifflier
Copy link
Member

fix published in release 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants