Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI Linkcheck green again #2031

Open
marxin opened this issue Jul 29, 2024 · 2 comments
Open

Make CI Linkcheck green again #2031

marxin opened this issue Jul 29, 2024 · 2 comments
Labels
A-linkcheck Area: linkcheck C-CI Category: CI for this repo

Comments

@marxin
Copy link
Contributor

marxin commented Jul 29, 2024

After the recent effort, one can run full Linkcheck locally and all links are valid now.

However, the GitHub Action CI is still unhappy for 2 reasons:

  • Server returned 429 Too Many Requests for - these are a known limitation and the effect of the linkcheck cache that is not persisted and reused (I've got a WIP changes: Save linkcheck cache always #2030)

  • Server returned 403/500 Internal Server Error for - these errors are very weird and I don't have a clue what can cause that:

error: Server returned 500 Internal Server Error for https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3AS-inactive+is%3Aclosed
    ┌─ getting-started.md:145:67
    │
145 │ these PRs and pick up the work. You can find the list of such PRs [here][abandoned-prs].
    │                                                                   ^^^^^^^^^^^^^^^^^^^^^ Server returned 500 Internal Server Error for https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3AS-inactive+is%3Aclosed

error: Server returned 403 Forbidden for https://github.com/bors
   ┌─ about-this-guide.md:77:7
   │
77 │ - For [@bors], [this cheat sheet][cheatsheet] is helpful
   │       ^^^^^^^ Server returned 403 Forbidden for https://github.com/bors

error: Server returned 403 Forbidden for https://github.com/bors
  ┌─ tests/ci.md:9:32
  │
9 │ - When the PR is approved, the [bors] bot enqueues the PR into a [merge queue].
  │                                ^^^^^^ Server returned 403 Forbidden for https://github.com/bors

error: Server returned 403 Forbidden for https://github.com/bors
    ┌─ tests/ci.md:1[30](https://github.com/rust-lang/rustc-dev-guide/actions/runs/10133701540/job/28019147907#step:7:31):46
    │
130 │ all PRs have to be approved through our bot, [bors] (the software behind it is
    │                                              ^^^^^^ Server returned 403 Forbidden for https://github.com/bors
@marxin
Copy link
Contributor Author

marxin commented Aug 17, 2024

I investigated that Server returned 403 Forbidden for https://github.com/bors errors are caused by legacy openssl package being used by mdbook-linkcheck. The package update is needed here: Michael-F-Bryan/mdbook-linkcheck#82.

@marxin
Copy link
Contributor Author

marxin commented Aug 17, 2024

CC: @camelid

@jieyouxu jieyouxu added C-CI Category: CI for this repo A-linkcheck Area: linkcheck labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linkcheck Area: linkcheck C-CI Category: CI for this repo
Projects
None yet
Development

No branches or pull requests

2 participants