Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not clear what's worthy of relnotes #2014

Open
workingjubilee opened this issue Jul 14, 2024 · 1 comment
Open

It's not clear what's worthy of relnotes #2014

workingjubilee opened this issue Jul 14, 2024 · 1 comment
Labels
C-discussion Category: discussion T-compiler Relevant to compiler team T-release Relevant to release team

Comments

@workingjubilee
Copy link
Member

Not everything that should go in relnotes is flagged with the relnotes label. This is partly because it's not clear what is worth flagging with relnotes. I certainly have spent almost zero time thinking about whether I should be tagging things with relnotes, regardless of how impactful a change might be.

The dev guide mentions the relnotes label and what it means but doesn't explain how to decide when to assign it.

@jieyouxu jieyouxu added T-compiler Relevant to compiler team C-discussion Category: discussion T-release Relevant to release team labels Nov 2, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 2, 2024

This is also unclear in the reviewer guidance in the forge docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-discussion Category: discussion T-compiler Relevant to compiler team T-release Relevant to release team
Projects
None yet
Development

No branches or pull requests

2 participants