Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #133807: ci: Enable opt-dist for dist-aarch64-linux builds #135482

Open
1 of 3 tasks
rustbot opened this issue Jan 14, 2025 · 4 comments
Open
1 of 3 tasks
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

This issue tracks the release notes text for #133807.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Internal Changes
- [ci: Enable opt-dist for dist-aarch64-linux builds](https://github.com/rust-lang/rust/pull/133807)
The ARM 64-bit compiler (AArch64) on Linux is now optimized with ThinLTO and PGO, similar to the optimizations we have already performed for the x86-64 compiler on Linux. This should make it up to 30% faster.

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @mrkajetanp, @Kobzol -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 14, 2025
@mrkajetanp
Copy link
Contributor

s/Aarch64/AArch64 but looks good otherwise :)

@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed A-testsuite Area: The testsuite used to check the correctness of rustc needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 14, 2025
@lqd
Copy link
Member

lqd commented Jan 14, 2025

maybe even s/LTO/ThinLTO/

@Noratrieb
Copy link
Member

and a s/x64/x86-64/ because replacements are so much fun

@rustbot rustbot added this to the 1.86.0 milestone Jan 15, 2025
@adamgemmell
Copy link
Contributor

#135262 also included some notable compile time improvements that weren't included in the benchmarks posted for this PR. This is due to setting rust.jemalloc and and llvm.thin-lto we presume, placing the mean for rustc-perf about -13.46% for that PR.

Total rustc-perf improvements on the debug-full profile across both PRs look something like up to 45%, with a 35% improvement for bootstrap/rustc-total. I don't currently have a mean value across both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants