Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc built from a source tarball reports it's nightly #124618

Closed
psumbera opened this issue May 2, 2024 · 4 comments · Fixed by #125181
Closed

rustc built from a source tarball reports it's nightly #124618

psumbera opened this issue May 2, 2024 · 4 comments · Fixed by #125181
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@psumbera
Copy link
Contributor

psumbera commented May 2, 2024

On Solaris I get following:

rustc --version
rustc 1.77.0-nightly (aedd173a2 2024-03-17) (built from a source tarball)

I'm confused about -nightly part.

Is it expected behavior?
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 2, 2024
@ehuss
Copy link
Contributor

ehuss commented May 2, 2024

What is the config.toml settings and command you used to build?

There is a setting in config.toml for setting the channel.

@psumbera
Copy link
Contributor Author

psumbera commented May 3, 2024

I had to add --release-channel=stable. Which results in channel = 'stable' in config.toml. This resolved the issue.

Question is whether channel shouldn't be always stable when building from official source tarball.

@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-discussion Category: Discussion or questions that doesn't represent real issues. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 13, 2024
@onur-ozkan
Copy link
Member

onur-ozkan commented May 16, 2024 •
edited

I had to add --release-channel=stable. Which results in channel = 'stable' in config.toml. This resolved the issue.

Question is whether channel shouldn't be always stable when building from official source tarball.

Currently it's not possible because we don't have any state file in the source tarballs to determine whether they are stable, beta or nightly.

I was wrong, see #124618 (comment).

@ehuss
Copy link
Contributor

ehuss commented May 16, 2024

src/ci/channel should indicate what channel the source distribution is for.

@onur-ozkan onur-ozkan mentioned this issue May 16, 2024
Merged
@bors bors closed this as completed in 52de709 May 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 17, 2024
@rust-timer
Unrolled build for rust-lang#125181
34101fc 
Rollup merge of rust-lang#125181 - onur-ozkan:set-rust-channel-properly, r=clubby789

set `rust.channel` properly in source tarballs

This change sets the appropriate channel by default when using nightly, beta or stable source tarballs.

Fixes rust-lang#124618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set rust.channel properly in source tarballs onur-ozkan/rust
5 participants
@ehuss @psumbera @jieyouxu @onur-ozkan @rustbot