Emit missing_const_for_fn for CONST_MUT_REFS#13839
Merged
Alexendoo merged 1 commit intorust-lang:masterfrom Jan 18, 2025
Merged
Emit missing_const_for_fn for CONST_MUT_REFS#13839Alexendoo merged 1 commit intorust-lang:masterfrom
missing_const_for_fn for CONST_MUT_REFS#13839Alexendoo merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
tomcur
force-pushed
the
const-mut-refs
branch
from
df9d631 to
f327640
Compare
Contributor
Author
|
Rebased to fix conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.83 stabilized
CONST_MUT_REFS, also allowing forconst fnto mutate through mutable references. This ensuresmissing_const_for_fnis emitted for those cases.changelog: [
missing_const_for_fn]: Now suggests marking some functions taking mutable referencesconst