-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix grammatical error in lint_groups_priority diagnostic suggestion #16812
Copy link
Copy link
Open
Labels
C-bugCategory: Clippy is not doing the correct thingCategory: Clippy is not doing the correct thing
Description
Summary
Currently, when the clippy::lint_groups_priority lint is triggered, the diagnostic suggestion is missing a comma, which makes the phrasing grammatically confusing.
The current output is:
"to have lints override the group set `{group_name}` to a lower priority"
Proposed Fix: Add a comma to separate the clauses for better readability:
"to have lints override the group, set `{group_name}` to a lower priority"
Implementation details: The missing punctuation is located in clippy_lints/src/cargo/lint_groups_priority.rs.
Fixing this will also require running cargo uibless to update the corresponding .stderr files in the ui-cargo/lint_groups_priority test suite.
Reproducer
Code:
<code>Current output:
Desired output:
Version
Additional Labels
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCategory: Clippy is not doing the correct thingCategory: Clippy is not doing the correct thing
Type
Fields
Give feedbackNo fields configured for issues without a type.