iter::repeat(copy_value).take(n) => repeat_n(copy_value, n) #13271

leonardo-m · 2024-08-15T18:36:02Z

What it does

Once repeat_n has being stabilized, it suggests to replace repeat+take with repeat_n in some simple cases.

Advantage

Shorter code, less tokens for the programmer mind.

Drawbacks

I can't think any.

Example

#![feature(iter_repeat_n)]
use std::iter;
fn main() {
    for x in iter::repeat(10).take(3) {
        print!("{x} ");
    }
    println!();
}

Could be written as:

#![feature(iter_repeat_n)]
use std::iter;
fn main() {
    for x in iter::repeat_n(10, 3) {
        print!("{x} ");
    }
    println!();
}

leonardo-m added the A-lint Area: New lints label Aug 15, 2024

lapla-cogito linked a pull request Dec 20, 2024 that will close this issue

add a new lint for repeat().take() that can be replaced with repeat_n() #13858

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iter::repeat(copy_value).take(n) => repeat_n(copy_value, n) #13271

iter::repeat(copy_value).take(n) => repeat_n(copy_value, n) #13271

leonardo-m commented Aug 15, 2024

iter::repeat(copy_value).take(n) => repeat_n(copy_value, n) #13271

iter::repeat(copy_value).take(n) => repeat_n(copy_value, n) #13271

Comments

leonardo-m commented Aug 15, 2024

What it does

Advantage

Drawbacks

Example