correct suggestion for manual_div_ceil lint
#13864
Open
+255
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
commented
Dec 22, 2024
lapla-cogito
force-pushed
the
issue_13843
branch
2 times, most recently
from
13e5caf to
67aec36
Compare
lapla-cogito
commented
Dec 22, 2024
clippy_lints/src/manual_div_ceil.rs
Outdated
Comment on lines
157
to
159
| let type_suffix = if cx.typeck_results().expr_ty(lhs).is_numeric() | ||
| && !is_include_type_suffix(cx, lhs) | ||
| && matches!(lhs.kind, ExprKind::Lit(_) | ExprKind::Unary(_, _)) | ||
| { | ||
| format!("_{}", cx.typeck_results().expr_ty(rhs)) | ||
| } else { | ||
| String::new() | ||
| }; |
There was a problem hiding this comment.
If lhs is a numeric and a literal (e.g. 3) or unary (e.g. -3) that needs to be type-suffixed, make the type suffix to match the type of rhs here.
lapla-cogito
force-pushed
the
issue_13843
branch
from
67aec36 to
de86302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13843
The
manual_div_ceillint makes incorrect suggestion when type suffixes need to be made explicit in the suggested code.changelog: [
manual_div_ceil]: suggested code now includes appropriate type suffixes where necessary