-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Remove ErrorKind
from digital
and pwm
modules
#527
Comments
it's not useless, HALs can still return their own error enums with more variants than the ones defined in
if you mean removing if you mean removing |
embedded-hal
defines its ownError
traits for each submodule, which makes sense since it wants thekind
method.I think this trait should've been a subtrait of
core::error::Error
, though I get why it isn't -Display
isn't as useful, and the standard library's error trait is not yet stable incore
- so I won't belabour this point further, it's more important to ship av1.0
than to wait for that stabilization.However, both
embedded_hal::digital::ErrorKind
andembedded_hal::pwm::ErrorKind
only contain one variantOther
, which means it is currently completely useless. So I'd suggest to remove these for now, until the need arises.This would be unlikely to be SemVer breaking to change back in the future (you could re-add the method with a default implementation of
ErrorKind::Other
), if we do find that we want to re-add error kinds for thedigital
andpwm
modules.The text was updated successfully, but these errors were encountered: