Clean up imports, fix doc lints, get doctests to pass #59
+10
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejpster
reviewed
Jul 20, 2025
| /// | ||
| /// It provides conversion functions to and from raw numbers. | ||
| /// *Note*: If you are in a `no_std` environment, you have to |
There was a problem hiding this comment.
We could probably replace all the std:: uses with core:: - that is available for libstd users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #58, this cleans up the following:
This cleanup also made the example in
measurements.rsdiscoverable as a doc test, and it didn't pass due to the![no_std]configuration. Removed the![no_std]configuration in the example, reordered the description such that the example now also shows up in the docs, and added a note that inno_stdenvironments,use core as stdis required when using the macros.