Skip to content

DEFAULT_CONFTEST_VERSION should be available at runtime #5996

@nvanheuverzwijn

Description

@nvanheuverzwijn

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

When starting atlantis version 0.36.0 (0.37.1 is affected as well), DEFAULT_CONFTEST_VERSION is not defined. This will always print the info log failed to get default conftest version. Will attempt request scoped lazy loads DEFAULT_CONFTEST_VERSION not set. Starting atlantis with default configuration should not log errors like this. DEFAULT_CONFTEST_VERSION should be available in runtime, especially because we use this environment variable to download conftest on build time.

Reproduction Steps

Executing this will print out the error log.

docker run -it ghcr.io/runatlantis/atlantis:v0.36.0 atlantis server --gh-user=test --gh-token=test --repo-allowlist=test

Logs

Environment details

atlantis version: 0.36 and 0.37.1

Additional Context

We should add DEFAULT_CONFTEST_VERSION available to stock container image. The source code is using this environment variable so it should always be defined with a default value. The operator should explicitly unset the environment variable if he wants to keep this behavior. I think it's unreasonable to have to specify DEFAULT_CONFTEST_VERSION, especially since we download conftest at build time using this variable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions