Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/metrics endpoint on a different port #5138

Open
matt-matt-tmatt opened this issue Dec 3, 2024 · 1 comment
Open

/metrics endpoint on a different port #5138

matt-matt-tmatt opened this issue Dec 3, 2024 · 1 comment
Labels
feature New functionality/enhancement

Comments

@matt-matt-tmatt
Copy link

matt-matt-tmatt commented Dec 3, 2024

Hey, I'd like to propose exposing the /metrics endpoint to a different port. The current setup makes it impossible to enforce mTLS in Istio while scrapping metrics using basic authentication. This seems to be a common pattern on other apps like Karpenter or Argo Workflows

With this feature implemented, only metrics traffic could bypass the Envoy proxy on the metrics port while maintaining encrypted traffic for incoming webhooks on a different port. This would be ideal considering the high amount of privileges Atlantis usually has.

This is unfortunately above my Go knowledge to open a PR, but I'd like to open the discussion at least.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
@matt-matt-tmatt matt-matt-tmatt added the feature New functionality/enhancement label Dec 3, 2024
@matt-matt-tmatt
Copy link
Author

matt-matt-tmatt commented Dec 3, 2024

Another option could be to have /metrics as unprotected. Istio can merge application metrics and expose them on port 15020. I couldn't find any Istio documentation regarding using merging on a protected endpoint but should work with this change implemented according to the docs at least. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

1 participant