-
Notifications
You must be signed in to change notification settings - Fork 36
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quality of life: when duplicate a job, don't redact environment variables in task if it inherit from input #337
Comments
This is due to your environment variable named SECRET. A quick fix would be to rename it to something else. That being said, I do plan on adding a top level job |
My intention is to redact everything. I have the secret pattern config like this: [middleware.job.redact]
enabled = true
patterns = ["*"] But that is not relevant to the point I'm making. I'm just proposing that maybe don't redact the variables whose value is inherited from inputs, because it's not the actual content anyway. |
Parsing the value has too many edge cases. Example:
So if I don't redact this it will have the secret in the clear. That's why I'm thinking of adding a new secrets construct that will be more explicit. |
The new secret feature suffice my needs. Thank you. |
Hi, when I duplicate a job, the task environment variables that are matched with secret pattern will be replaced its value with
"[REDACTED]"
, even if it only inherit the value from inputsFor example:
When duplicating this job, it's definition become
The second redaction is unnecessary.
The text was updated successfully, but these errors were encountered: