-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strong typing for LlamaIndexTS #739
Labels
enhancement
New feature or request
Comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've noticed most of the PRs recently are generated by LLM, and this project has had some issues.
For example, this API doesn't tell what are
objects
,indexCls
, andindexKwargs
. Even though there's some trouble, it won't get fixed as time passes.LlamaIndexTS/packages/core/src/objects/base.ts
Lines 155 to 161 in 208282d
Not a good design; it's just a literary copy-pasted version of
llama index
Python code. llama index is a widely validated and used package, but some architectures are unsuitable for JS/TS. I listed here:sync
call on the JS side, so every function call relies on LLM (uses network request) and is async-forced.fromDefaults
|fromObjects
... which you can rename them all intofrom
and use typescript function overloading to handle it, which will simplify the APIsNo testing; each feature only added example code but did not fully cover the features and might have regression in the future.
Some PRs need to be reworked to fit the strong type:
Related issues:
The text was updated successfully, but these errors were encountered: