-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt upstream version scheme #369
Comments
I think this makes sense. I don't see an immediate problem with upgrading from v3 (current) to v8. |
Cool! Once you make this change, I'd be happy to provide a PR for an automated GitHub action which periodically checks whether the local version matches the upstream version so you don't need to monitor the I did the same for the Python package: daviddrysdale/python-phonenumbers#275 |
Hi @ruimarinho I hope you are well? Have you given any additional thought to my suggestion of adopting the upstream numbering? |
First of all thanks for providing this library, it's still the most convenient way to install
libphonenumber
out there!Since what this package provides is an unmodified version of the upstream library, wouldn't it make sense to just use the same version number?
This would make it much easier to track which upstream version you are providing. It is also the approach taken by the Python version of
libphonenumber
: https://github.com/daviddrysdale/python-phonenumbersThe text was updated successfully, but these errors were encountered: