-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle outdated's exit status is always 1, even when outdated gems are filtered out when filtering on groups #7425
Comments
That sounds like a valid bug to me! Happy to get a PR to fix it. |
Agreed! |
Excellent news! I'll put something together when I've got a gap this week. |
@gee-forr Still interested in contributing this? Any help needed? |
Hey @deivid-rodriguez - Yeah - I still 100% plan on issuing a PR. I've just had an intense 2024 so far in terms of work commitments. As soon as my work load subsides a little, I'll have some time to issue a fix. Apologies for the wait. |
The problem
I'd like to start using
bundle outdated --only-explicit
in my CI pipelines to warn when our gems are getting outdated.The problem is, if there are outdated gems and they're filtered out, the exit status is still 1, when I would expect it to be 0.
I've taken a look at the
lib/cli/outdated.rb
code and believe I can fix this issue, and I'm happy to push a PR if you believe this is a valid bug?Did you try upgrading rubygems & bundler?
This bug is present in the latest version of bundler, and the latest version of the code here on github.
Post steps to reproduce the problem
Use this gemfile:
Run these commands:
No minor updates to display.
and return with an exit status of 0, but instead shows the output header, and exits with a status of 1Which command did you run?
bundle outdated --only-explicit --filter-minor --filter-patch --group foo
on a Gemfile with no minor or patch version updates availableWhat were you expecting to happen?
I was expecting
bundle outdated
to exit with a status of 0What actually happened?
It exits with a status of 1
The text was updated successfully, but these errors were encountered: