New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Settings to Config and display deprecation warning until next major version bump #118
Comments
This sounds good to me. But could it potentially crash with a rails class? I'm not sure if there is already a Config class or not... If not, it would be beneficial to the consistency for the user. |
Hi there, I just had a look at this library and as a heavy Sinatra user the first thing I thought was that Regards, |
I think we already have Sinatra as part of our test scope and it seems to work fine with current setup... |
@pkuczynski Fair enough, I'm just saying that it looks like the kind of thing that if another dev on a team came to me with two vars only differing by case then I'd be worried that a bug will appear. Seems like an accident waiting to happen. Regards, |
As we renamed the gem from RailsConfig to Config I think we should also rename the global variable name from Settings to Config, keeping both access points available and displaying deprecation warning until the next major version bump.
@fredwu what do you think?
The text was updated successfully, but these errors were encountered: